* [PATCH] staging: ralink-gdma: Prefer u32 over uint32_t
@ 2019-03-21 18:37 Bharath Vedartham
2019-03-21 18:46 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Bharath Vedartham @ 2019-03-21 18:37 UTC (permalink / raw)
To: gregkh, christian; +Cc: devel, linux-kernel
Change uint32_t to u32
Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
---
drivers/staging/ralink-gdma/ralink-gdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
index d78042e..2c19287 100644
--- a/drivers/staging/ralink-gdma/ralink-gdma.c
+++ b/drivers/staging/ralink-gdma/ralink-gdma.c
@@ -361,7 +361,7 @@ static int rt3883_gdma_start_transfer(struct gdma_dmaengine_chan *chan)
struct gdma_dma_dev *dma_dev = gdma_dma_chan_get_dev(chan);
dma_addr_t src_addr, dst_addr;
struct gdma_dma_sg *sg;
- uint32_t ctrl0, ctrl1;
+ u32 ctrl0, ctrl1;
/* verify chan is already stopped */
ctrl0 = gdma_dma_read(dma_dev, GDMA_REG_CTRL0(chan->id));
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: ralink-gdma: Prefer u32 over uint32_t
2019-03-21 18:37 [PATCH] staging: ralink-gdma: Prefer u32 over uint32_t Bharath Vedartham
@ 2019-03-21 18:46 ` Greg KH
2019-03-21 18:48 ` Bharath Vedartham
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2019-03-21 18:46 UTC (permalink / raw)
To: Bharath Vedartham; +Cc: christian, devel, linux-kernel
On Fri, Mar 22, 2019 at 12:07:10AM +0530, Bharath Vedartham wrote:
> Change uint32_t to u32
That says _what_ you did, but _why_ are you doing this? That's the main
content a changelog text should have in it.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: ralink-gdma: Prefer u32 over uint32_t
2019-03-21 18:46 ` Greg KH
@ 2019-03-21 18:48 ` Bharath Vedartham
2019-03-21 18:54 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Bharath Vedartham @ 2019-03-21 18:48 UTC (permalink / raw)
To: Greg KH; +Cc: christian, devel, linux-kernel
On Thu, Mar 21, 2019 at 07:46:09PM +0100, Greg KH wrote:
> On Fri, Mar 22, 2019 at 12:07:10AM +0530, Bharath Vedartham wrote:
> > Change uint32_t to u32
>
> That says _what_ you did, but _why_ are you doing this? That's the main
> content a changelog text should have in it.
>
> thanks,
>
> greg k-h
That was a checkpatch.pl warning! I forgot to mention that! It fixed a
checkpatch.pl warning. I ll write better changelogs from my next commit
on. Thanks for the feedback!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: ralink-gdma: Prefer u32 over uint32_t
2019-03-21 18:48 ` Bharath Vedartham
@ 2019-03-21 18:54 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2019-03-21 18:54 UTC (permalink / raw)
To: Bharath Vedartham; +Cc: devel, christian, linux-kernel
On Fri, Mar 22, 2019 at 12:18:58AM +0530, Bharath Vedartham wrote:
> On Thu, Mar 21, 2019 at 07:46:09PM +0100, Greg KH wrote:
> > On Fri, Mar 22, 2019 at 12:07:10AM +0530, Bharath Vedartham wrote:
> > > Change uint32_t to u32
> >
> > That says _what_ you did, but _why_ are you doing this? That's the main
> > content a changelog text should have in it.
> >
> > thanks,
> >
> > greg k-h
> That was a checkpatch.pl warning! I forgot to mention that! It fixed a
> checkpatch.pl warning. I ll write better changelogs from my next commit
> on. Thanks for the feedback!
Please fix this up and resend as a "v2" patch, if you wish to have it
accepted.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-21 18:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-21 18:37 [PATCH] staging: ralink-gdma: Prefer u32 over uint32_t Bharath Vedartham
2019-03-21 18:46 ` Greg KH
2019-03-21 18:48 ` Bharath Vedartham
2019-03-21 18:54 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox