From: Joerg Roedel <joro@8bytes.org>
To: Robert Richter <rrichter@marvell.com>
Cc: Robin Murphy <robin.murphy@arm.com>,
Ganapatrao Kulkarni <gkulkarni@marvell.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] iommu/iova: Fix tracking of recently failed iova address
Date: Fri, 22 Mar 2019 10:31:46 +0100 [thread overview]
Message-ID: <20190322093146.GA18669@8bytes.org> (raw)
In-Reply-To: <20190320185718.jhr6gvs7jdbn4x3p@rric.localdomain>
On Wed, Mar 20, 2019 at 06:57:23PM +0000, Robert Richter wrote:
> From: Robert Richter <rrichter@marvell.com>
> Subject: [PATCH v2] iommu/iova: Fix tracking of recently failed iova address
> size
>
> If a 32 bit allocation request is too big to possibly succeed, it
> early exits with a failure and then should never update max32_alloc_
> size. This patch fixes current code, now the size is only updated if
> the slow path failed while walking the tree. Without the fix the
> allocation may enter the slow path again even if there was a failure
> before of a request with the same or a smaller size.
>
> Cc: <stable@vger.kernel.org> # 4.20+
> Fixes: bee60e94a1e2 ("iommu/iova: Optimise attempts to allocate iova from 32bit address range")
> Signed-off-by: Robert Richter <rrichter@marvell.com>
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Robert Richter <rrichter@marvell.com>
> ---
> drivers/iommu/iova.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Applied, thanks.
prev parent reply other threads:[~2019-03-22 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 15:56 [PATCH] iommu/iova: Fix tracking of recently failed iova address size Robert Richter
2019-03-18 15:19 ` Robin Murphy
2019-03-20 18:57 ` [PATCH v2] iommu/iova: Fix tracking of recently failed iova address Robert Richter
2019-03-22 9:31 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322093146.GA18669@8bytes.org \
--to=joro@8bytes.org \
--cc=gkulkarni@marvell.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=rrichter@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox