public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: ralink-gdma: Change uint32_t to u32
@ 2019-03-21 19:25 Bharath Vedartham
  2019-03-22 10:01 ` Dan Carpenter
  0 siblings, 1 reply; 3+ messages in thread
From: Bharath Vedartham @ 2019-03-21 19:25 UTC (permalink / raw)
  To: gregkh, christian; +Cc: devel, linux-kernel

This is a follow up on my previous patch. Change occurences of the
stdint type uint32_t to its shortened type u32. This fixed the checkpatch.pl warning: "Prefer u32 over uint32_t".

Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
---
 drivers/staging/ralink-gdma/ralink-gdma.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
index 2c19287..7e824d3 100644
--- a/drivers/staging/ralink-gdma/ralink-gdma.c
+++ b/drivers/staging/ralink-gdma/ralink-gdma.c
@@ -157,14 +157,14 @@ static struct gdma_dma_desc *to_gdma_dma_desc(struct virt_dma_desc *vdesc)
 	return container_of(vdesc, struct gdma_dma_desc, vdesc);
 }
 
-static inline uint32_t gdma_dma_read(struct gdma_dma_dev *dma_dev,
+static inline u32 gdma_dma_read(struct gdma_dma_dev *dma_dev,
 				     unsigned int reg)
 {
 	return readl(dma_dev->base + reg);
 }
 
 static inline void gdma_dma_write(struct gdma_dma_dev *dma_dev,
-				  unsigned reg, uint32_t val)
+				  unsigned reg, u32 val)
 {
 	writel(val, dma_dev->base + reg);
 }
@@ -283,7 +283,7 @@ static int rt305x_gdma_start_transfer(struct gdma_dmaengine_chan *chan)
 	struct gdma_dma_dev *dma_dev = gdma_dma_chan_get_dev(chan);
 	dma_addr_t src_addr, dst_addr;
 	struct gdma_dma_sg *sg;
-	uint32_t ctrl0, ctrl1;
+	u32 ctrl0, ctrl1;
 
 	/* verify chan is already stopped */
 	ctrl0 = gdma_dma_read(dma_dev, GDMA_REG_CTRL0(chan->id));
@@ -753,7 +753,7 @@ static void gdma_dma_tasklet(unsigned long arg)
 
 static void rt305x_gdma_init(struct gdma_dma_dev *dma_dev)
 {
-	uint32_t gct;
+	u32 gct;
 
 	/* all chans round robin */
 	gdma_dma_write(dma_dev, GDMA_RT305X_GCT, GDMA_REG_GCT_ARBIT_RR);
@@ -767,7 +767,7 @@ static void rt305x_gdma_init(struct gdma_dma_dev *dma_dev)
 
 static void rt3883_gdma_init(struct gdma_dma_dev *dma_dev)
 {
-	uint32_t gct;
+	u32 gct;
 
 	/* all chans round robin */
 	gdma_dma_write(dma_dev, GDMA_REG_GCT, GDMA_REG_GCT_ARBIT_RR);
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: ralink-gdma: Change uint32_t to u32
  2019-03-21 19:25 [PATCH] staging: ralink-gdma: Change uint32_t to u32 Bharath Vedartham
@ 2019-03-22 10:01 ` Dan Carpenter
  2019-03-22 12:04   ` Bharath Vedartham
  0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2019-03-22 10:01 UTC (permalink / raw)
  To: Bharath Vedartham; +Cc: gregkh, christian, devel, linux-kernel

On Fri, Mar 22, 2019 at 12:55:02AM +0530, Bharath Vedartham wrote:
> This is a follow up on my previous patch. Change occurences of the
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Put this sort of information under the --- cut off below the Sign off.

> stdint type uint32_t to its shortened type u32. This fixed the checkpatch.pl warning: "Prefer u32 over uint32_t".

This line is too long.  Limit it to 72 characters.

> 
> Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
> ---
  ^^^

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: ralink-gdma: Change uint32_t to u32
  2019-03-22 10:01 ` Dan Carpenter
@ 2019-03-22 12:04   ` Bharath Vedartham
  0 siblings, 0 replies; 3+ messages in thread
From: Bharath Vedartham @ 2019-03-22 12:04 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: gregkh, christian, devel, linux-kernel

On Fri, Mar 22, 2019 at 01:01:40PM +0300, Dan Carpenter wrote:
> On Fri, Mar 22, 2019 at 12:55:02AM +0530, Bharath Vedartham wrote:
> > This is a follow up on my previous patch. Change occurences of the
>   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
I did not send a patch set. I should have worded my changelog better.
Thanks for the feedback. This was just one patch.
> Put this sort of information under the --- cut off below the Sign off.
> 
> > stdint type uint32_t to its shortened type u32. This fixed the checkpatch.pl warning: "Prefer u32 over uint32_t".
> 
> This line is too long.  Limit it to 72 characters.
> 
Yes will do that.
> > 
> > Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
> > ---
>   ^^^
Got it. Thanks for the feedback.
> 
> regards,
> dan carpenter
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-03-22 12:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-21 19:25 [PATCH] staging: ralink-gdma: Change uint32_t to u32 Bharath Vedartham
2019-03-22 10:01 ` Dan Carpenter
2019-03-22 12:04   ` Bharath Vedartham

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox