From: Pavel Machek <pavel@ucw.cz>
To: Nick Crews <ncrews@chromium.org>
Cc: enric.balletbo@collabora.com, bleung@chromium.org,
linux-leds@vger.kernel.org, jacek.anaszewski@gmail.com,
linux-kernel@vger.kernel.org, dlaurie@chromium.org,
sjg@google.com, groeck@google.com, dtor@google.com
Subject: Re: [PATCH 3/3] platform/chrome: Add Wilco EC keyboard backlight LEDs support
Date: Fri, 22 Mar 2019 12:35:09 +0100 [thread overview]
Message-ID: <20190322113509.GE8681@amd> (raw)
In-Reply-To: <20190321221334.240059-3-ncrews@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 590 bytes --]
Hi!
> The EC is in charge of controlling the keyboard backlight on
> the Wilco platform. We expose a standard LED class device at
> /sys/class/leds/wilco::kbd_backlight. This driver is modeled
> after the standard Chrome OS keyboard backlight driver at
> drivers/platform/chrome/cros_kbd_led_backlight.c
Please make it platform::kbd_backlight . Userland should not need to
know what wilco is...
What is wilco, anyway?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-03-22 13:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 22:13 [PATCH 1/3] platform/chrome: wilco_ec: Split core and mailbox into separate modules Nick Crews
2019-03-21 22:13 ` [PATCH 2/3] platform/chrome: wilco_ec: Standardize mailbox interface Nick Crews
2019-03-21 22:13 ` [PATCH 3/3] platform/chrome: Add Wilco EC keyboard backlight LEDs support Nick Crews
2019-03-22 11:35 ` Pavel Machek [this message]
2019-03-22 15:49 ` Nick Crews
2019-03-25 20:24 ` Nick Crews
2019-03-25 20:48 ` Dmitry Torokhov
2019-03-25 17:18 ` [PATCH 1/3] platform/chrome: wilco_ec: Split core and mailbox into separate modules Enric Balletbo i Serra
2019-03-25 18:22 ` Nick Crews
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322113509.GE8681@amd \
--to=pavel@ucw.cz \
--cc=bleung@chromium.org \
--cc=dlaurie@chromium.org \
--cc=dtor@google.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@google.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=ncrews@chromium.org \
--cc=sjg@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox