From: Borislav Petkov <bp@alien8.de>
To: Rui Zhao <ruizhao@outlook.com>,
"james.morse@arm.com" <james.morse@arm.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"okaya@kernel.org" <okaya@kernel.org>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"sashal@kernel.org" <sashal@kernel.org>,
"hangl@microsoft.com" <hangl@microsoft.com>,
"lewan@microsoft.com" <lewan@microsoft.com>,
Rui Zhao <ruizhao@microsoft.com>
Subject: Re: [PATCH v2 1/2] EDAC: add EDAC driver for DMC520
Date: Sat, 23 Mar 2019 10:23:42 +0100 [thread overview]
Message-ID: <20190323092342.GD23698@zn.tnic> (raw)
In-Reply-To: <BN7PR08MB5572D3A5217C4749AC4E7DC4AE4C0@BN7PR08MB5572.namprd08.prod.outlook.com>
Just some initial comments. The general direction of this should be
looked at by James.
On Thu, Mar 07, 2019 at 01:24:01AM +0000, Rui Zhao wrote:
> From: Rui Zhao <ruizhao@microsoft.com>
>
> New driver supports error detection and correction on
> the devices with ARM DMC-520 memory controller.
>
> Signed-off-by: Rui Zhao <ruizhao@microsoft.com>
> ---
> MAINTAINERS | 6 +
> drivers/edac/Kconfig | 7 +
> drivers/edac/Makefile | 1 +
> drivers/edac/dmc520_edac.c | 619 +++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 633 insertions(+)
> create mode 100644 drivers/edac/dmc520_edac.c
...
> diff --git a/drivers/edac/Makefile b/drivers/edac/Makefile
> index 716096d..793d64f 100644
> --- a/drivers/edac/Makefile
> +++ b/drivers/edac/Makefile
> @@ -78,3 +78,4 @@ obj-$(CONFIG_EDAC_SYNOPSYS) += synopsys_edac.o
> obj-$(CONFIG_EDAC_XGENE) += xgene_edac.o
> obj-$(CONFIG_EDAC_TI) += ti_edac.o
> obj-$(CONFIG_EDAC_QCOM) += qcom_edac.o
> +obj-$(CONFIG_EDAC_DMC520) += dmc520_edac.o
> diff --git a/drivers/edac/dmc520_edac.c b/drivers/edac/dmc520_edac.c
> new file mode 100644
> index 0000000..c70ce4e
> --- /dev/null
> +++ b/drivers/edac/dmc520_edac.c
> @@ -0,0 +1,619 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +// EDAC driver for DMC-520
No "//" commenting in .c files. Make sure to have a cursory look at
Documentation/process/submitting-patches.rst
Also, this patch doesn't apply - please redo it against:
https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=for-next
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next parent reply other threads:[~2019-03-23 9:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BN7PR08MB5572D3A5217C4749AC4E7DC4AE4C0@BN7PR08MB5572.namprd08.prod.outlook.com>
2019-03-23 9:23 ` Borislav Petkov [this message]
2019-03-25 18:27 ` [PATCH v2 1/2] EDAC: add EDAC driver for DMC520 James Morse
2019-03-25 22:01 ` Borislav Petkov
2019-03-25 18:32 ` James Morse
2019-05-16 20:02 ` Lei Wang (BSP)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190323092342.GD23698@zn.tnic \
--to=bp@alien8.de \
--cc=devicetree@vger.kernel.org \
--cc=hangl@microsoft.com \
--cc=james.morse@arm.com \
--cc=lewan@microsoft.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=okaya@kernel.org \
--cc=robh+dt@kernel.org \
--cc=ruizhao@microsoft.com \
--cc=ruizhao@outlook.com \
--cc=sashal@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox