From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF273C4360F for ; Sun, 24 Mar 2019 12:25:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC290222D6 for ; Sun, 24 Mar 2019 12:25:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553430352; bh=FL3tEc7++85Ctteo5zQGlckdt3wcBl4YBAzOqEiKZOI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=loelahau+Xb+eYVKKUY3424jIUFGVJGL9yC2IT/hG2o2dkqyHV3OlMxEa/AvDWytX xknWoorVKK9fxrCi0IYbM5yes9EIxHfNSSp6ViBrtNFDQIeprJFTwqQHHd32BupOMG wnGMl4+BlmjB4QnOEc26BCnjyXj2ZxqjgLR+ncjM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728711AbfCXMZv (ORCPT ); Sun, 24 Mar 2019 08:25:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:48768 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726160AbfCXMZv (ORCPT ); Sun, 24 Mar 2019 08:25:51 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE476222C5; Sun, 24 Mar 2019 12:25:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553430350; bh=FL3tEc7++85Ctteo5zQGlckdt3wcBl4YBAzOqEiKZOI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=p5bgxZyA3UF3/2teLe1+8jKmvVpI/rbq1VXSaCVK9s1gJ4VtxA4aV20gzddA2rLzv ewUAPD5r5sDucrQVXpCbsG06NDqUqmvMyHmQilNk9eZrfKwFRN1BY53CiDGzEjbHHb +NRggoIRZShXFGENPFYGCFWdoPXjxx9Gkj5M+hgc= Date: Sun, 24 Mar 2019 12:25:44 +0000 From: Jonathan Cameron To: "Gustavo A. R. Silva" Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Daniel Drake , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: st_accel: remove unnecessary comparison of unsigned integer with < 0 Message-ID: <20190324122544.4fe69a14@archlinux> In-Reply-To: <20190318173302.GA10761@embeddedor> References: <20190318173302.GA10761@embeddedor> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Mar 2019 12:33:02 -0500 "Gustavo A. R. Silva" wrote: > There is no need to compare *val* with < 0 because such comparison > of an unsigned value is always false. > > Fix this by removing such comparison. > > Addresses-Coverity-ID: 1443919 ("Unsigned compared against 0") > Fixes: f38ab20b749d ("iio: st_accel: use ACPI orientation data") > Signed-off-by: Gustavo A. R. Silva Thanks, Colin King got there first and I have a patch fixing this queued up. Jonathan > --- > drivers/iio/accel/st_accel_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/accel/st_accel_core.c b/drivers/iio/accel/st_accel_core.c > index a3c0916479fa..9930edf423bf 100644 > --- a/drivers/iio/accel/st_accel_core.c > +++ b/drivers/iio/accel/st_accel_core.c > @@ -992,7 +992,7 @@ static int apply_acpi_orientation(struct iio_dev *indio_dev, > goto out; > > val = elements[i].integer.value; > - if (val < 0 || val > 2) > + if (val > 2) > goto out; > > /* Avoiding full matrix multiplication, we simply reorder the