From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CD71C10F00 for ; Sun, 24 Mar 2019 23:43:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6825620870 for ; Sun, 24 Mar 2019 23:43:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729161AbfCXXnD (ORCPT ); Sun, 24 Mar 2019 19:43:03 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:48996 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729107AbfCXXnC (ORCPT ); Sun, 24 Mar 2019 19:43:02 -0400 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2ONcUV1083652 for ; Sun, 24 Mar 2019 19:43:01 -0400 Received: from e13.ny.us.ibm.com (e13.ny.us.ibm.com [129.33.205.203]) by mx0a-001b2d01.pphosted.com with ESMTP id 2red2ywcjc-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 24 Mar 2019 19:43:01 -0400 Received: from localhost by e13.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 24 Mar 2019 23:43:00 -0000 Received: from b01cxnp22036.gho.pok.ibm.com (9.57.198.26) by e13.ny.us.ibm.com (146.89.104.200) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Sun, 24 Mar 2019 23:42:56 -0000 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x2ONgtrY17957070 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 24 Mar 2019 23:42:55 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 33BD0B2064; Sun, 24 Mar 2019 23:42:55 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 06032B205F; Sun, 24 Mar 2019 23:42:55 +0000 (GMT) Received: from paulmck-ThinkPad-W541 (unknown [9.70.82.188]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Sun, 24 Mar 2019 23:42:54 +0000 (GMT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id 5C2BE16C2DE1; Sun, 24 Mar 2019 16:43:51 -0700 (PDT) Date: Sun, 24 Mar 2019 16:43:51 -0700 From: "Paul E. McKenney" To: Joel Fernandes Cc: linux-kernel@vger.kernel.org, byungchul.park@lge.com, kernel-team@android.com, rcu@vger.kernel.org, Ingo Molnar , Josh Triplett , Lai Jiangshan , Mathieu Desnoyers , Peter Zijlstra , Steven Rostedt , Will Deacon Subject: Re: [RFC 2/2] rcutree: Add checks for dynticks counters in rcu_is_cpu_rrupt_from_idle Reply-To: paulmck@linux.ibm.com References: <20190323012939.15185-1-joel@joelfernandes.org> <20190323012939.15185-2-joel@joelfernandes.org> <20190323030251.GB136835@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190323030251.GB136835@google.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 19032423-0064-0000-0000-000003BF6C42 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010809; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000282; SDB=6.01179187; UDB=6.00617002; IPR=6.00959898; MB=3.00026141; MTD=3.00000008; XFM=3.00000015; UTC=2019-03-24 23:42:59 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19032423-0065-0000-0000-00003CD35880 Message-Id: <20190324234351.GX4102@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-24_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903240181 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 22, 2019 at 11:02:51PM -0400, Joel Fernandes wrote: > On Fri, Mar 22, 2019 at 09:29:39PM -0400, Joel Fernandes (Google) wrote: > > In the future we would like to combine the dynticks and dynticks_nesting > > counters thus leading to simplifying the code. At the moment we cannot > > do that due to concerns about usermode upcalls appearing to RCU as half > > of an interrupt. Byungchul tried to do it in [1] but the > > "half-interrupt" concern was raised. It is half because, what RCU > > expects is rcu_irq_enter() and rcu_irq_exit() pairs when the usermode > > exception happens. However, only rcu_irq_enter() is observed. This > > concern may not be valid anymore, but at least it used to be the case. > > > > Out of abundance of caution, Paul added warnings [2] in the RCU code > > which if not fired by 2021 may allow us to assume that such > > half-interrupt scenario cannot happen any more, which can lead to > > simplification of this code. > > > > Summary of the changes are the following: > > > > (1) In preparation for this combination of counters in the future, we > > first need to first be sure that rcu_rrupt_from_idle cannot be called > > from anywhere but a hard-interrupt because previously, the comments > > suggested otherwise so let us be sure. We discussed this here [3]. We > > use the services of lockdep to accomplish this. > > > > (2) Further rcu_rrupt_from_idle() is not explicit about how it is using > > the counters which can lead to weird future bugs. This patch therefore > > makes it more explicit about the specific counter values being tested > > > > (3) Lastly, we check for counter underflows just to be sure these are > > not happening, because the previous code in rcu_rrupt_from_idle() was > > allowing the case where the counters can underflow, and the function > > would still return true. Now we are checking for specific values so let > > us be confident by additional checking, that such underflows don't > > happen. Any case, if they do, we should fix them and the screaming > > warning is appropriate. All these checks checks are NOOPs if PROVE_RCU > > and PROVE_LOCKING are disabled. > > > > [1] https://lore.kernel.org/patchwork/patch/952349/ > > [2] Commit e11ec65cc8d6 ("rcu: Add warning to detect half-interrupts") > > [3] https://lore.kernel.org/lkml/20190312150514.GB249405@google.com/ > > > > Cc: byungchul.park@lge.com > > Cc: kernel-team@android.com > > Cc: rcu@vger.kernel.org > > Signed-off-by: Joel Fernandes (Google) > > --- > > kernel/rcu/tree.c | 21 +++++++++++++++++---- > > 1 file changed, 17 insertions(+), 4 deletions(-) > > > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > > index 9180158756d2..d94c8ed29f6b 100644 > > --- a/kernel/rcu/tree.c > > +++ b/kernel/rcu/tree.c > > @@ -381,16 +381,29 @@ static void __maybe_unused rcu_momentary_dyntick_idle(void) > > } > > > > /** > > - * rcu_is_cpu_rrupt_from_idle - see if idle or immediately interrupted from idle > > + * rcu_is_cpu_rrupt_from_idle - see if interrupted from idle > > * > > - * If the current CPU is idle or running at a first-level (not nested) > > + * If the current CPU is idle and running at a first-level (not nested) > > * interrupt from idle, return true. The caller must have at least > > * disabled preemption. > > */ > > static int rcu_is_cpu_rrupt_from_idle(void) > > { > > - return __this_cpu_read(rcu_data.dynticks_nesting) <= 0 && > > - __this_cpu_read(rcu_data.dynticks_nmi_nesting) <= 1; > > + /* Called only from within the scheduling-clock interrupt */ > > + lockdep_assert_in_irq(); > > + > > + /* Check for counter underflows */ > > + RCU_LOCKDEP_WARN( > > + (__this_cpu_read(rcu_data.dynticks_nesting) < 0) && > > + (__this_cpu_read(rcu_data.dynticks_nmi_nesting) < 0), > > > This condition for the warning is supposed to be || instead of &&. Sorry. > > Or, I will just use 2 RCU_LOCKDEP_WARN(s) here, that's better. Also, the dynticks_nmi_nesting being zero is a bug given that we know we are in an interrupt handler, right? Or am I off by one again? Thanx, Paul