From: Michal Kubecek <mkubecek@suse.cz>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: regression (bisected): "modprobe parport_pc" hangs in current mainline
Date: Mon, 25 Mar 2019 08:30:45 +0100 [thread overview]
Message-ID: <20190325073045.GC26076@unicorn.suse.cz> (raw)
In-Reply-To: <20190324193838.ubiljot22zhf5mjq@debian>
On Sun, Mar 24, 2019 at 07:38:38PM +0000, Sudip Mukherjee wrote:
> And I was able to reproduce the problem using a vm and Suse Tumblewood with
> next-20190322. Can you please try the attached patch and test on your vm and
> machine and check if it fixes the problem.
>
> --
> Regards
> Sudip
> diff --git a/drivers/parport/share.c b/drivers/parport/share.c
> index 0171b8dbcdcd..f87948fbfc34 100644
> --- a/drivers/parport/share.c
> +++ b/drivers/parport/share.c
> @@ -274,7 +274,7 @@ static int port_check(struct device *dev, void *dev_drv)
> int __parport_register_driver(struct parport_driver *drv, struct module *owner,
> const char *mod_name)
> {
> - if (list_empty(&portlist))
> + if (list_empty(&portlist) && strcmp(drv->name, "daisy_drv"))
> get_lowlevel_driver();
>
> if (drv->devmodel) {
Yes, with this patch (on top of v5.1-rc2), both physical machine and VM
let the module(s) load cleanly even with the alias line restored.
Tested-by: Michal Kubecek <mkubecek@suse.cz>
Thank you,
Michal
next prev parent reply other threads:[~2019-03-25 7:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 6:45 regression (bisected): "modprobe parport_pc" hangs in current mainline Michal Kubecek
2019-03-17 17:01 ` Sudip Mukherjee
2019-03-17 18:05 ` Michal Kubecek
2019-03-20 9:30 ` Sudip Mukherjee
2019-03-20 21:18 ` Michal Kubecek
2019-03-21 22:43 ` Sudip Mukherjee
2019-03-22 6:13 ` Michal Kubecek
2019-03-24 19:38 ` Sudip Mukherjee
2019-03-25 7:30 ` Michal Kubecek [this message]
2019-03-25 10:00 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325073045.GC26076@unicorn.suse.cz \
--to=mkubecek@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox