Re: [PATCH v2 4/4] drivers/base/memory.c: Rename the misleading parameter

Baoquan He
2019-03-26T12:42:51Z

On 03/26/19 at 04:43am, Matthew Wilcox wrote:
> On Tue, Mar 26, 2019 at 05:02:27PM +0800, Baoquan He wrote:
> > The input parameter 'phys_index' of memory_block_action() is actually
> > the section number, but not the phys_index of memory_block. Fix it.
>
> > static int
> > -memory_block_action(unsigned long phys_index, unsigned long action, int online_type)
> > +memory_block_action(unsigned long sec, unsigned long action, int online_type)
>
> 'sec' is a bad abbreviation for 'section'. We don't use it anyhere else
> in the vm.

Hmm, here 'sec' is in a particular context, we may not confuse it with
other abbreviation. Since Michal also complained about it, seems an
update is needed. I will change it to start_section_nr as Michal
suggested. Thanks.

>
> Looking through include/, I see it used as an abbreviation for second,
> security, ELF section, and section of a book. Nowhere as a memory
> block section. Please use an extra four letters for this parameter.