From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 773C0C43381 for ; Tue, 26 Mar 2019 14:30:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 504AB20857 for ; Tue, 26 Mar 2019 14:30:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731813AbfCZOap (ORCPT ); Tue, 26 Mar 2019 10:30:45 -0400 Received: from mga09.intel.com ([134.134.136.24]:19826 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726285AbfCZOao (ORCPT ); Tue, 26 Mar 2019 10:30:44 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2019 07:30:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,271,1549958400"; d="scan'208";a="158533382" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 26 Mar 2019 07:30:41 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 26 Mar 2019 16:30:40 +0200 Date: Tue, 26 Mar 2019 16:30:40 +0200 From: Heikki Krogerus To: Sakari Ailus Cc: Andy Shevchenko , Petr Mladek , linux-kernel@vger.kernel.org, rafael@kernel.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 5/5] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names Message-ID: <20190326143040.GF7049@kuha.fi.intel.com> References: <20190322152930.16642-1-sakari.ailus@linux.intel.com> <20190322152930.16642-6-sakari.ailus@linux.intel.com> <20190322172114.GY9224@smile.fi.intel.com> <20190324181745.vgckevapfwi7mul7@mara.localdomain> <20190326131353.GY9224@smile.fi.intel.com> <20190326140633.GE7049@kuha.fi.intel.com> <20190326141243.g2x44v65npw4yhw5@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190326141243.g2x44v65npw4yhw5@paasikivi.fi.intel.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 26, 2019 at 04:12:43PM +0200, Sakari Ailus wrote: > Moi, > > On Tue, Mar 26, 2019 at 04:06:33PM +0200, Heikki Krogerus wrote: > > Hi, > > > > On Tue, Mar 26, 2019 at 03:13:53PM +0200, Andy Shevchenko wrote: > > > > > > On ACPI based systems the resulting strings look like > > > > > > > > > > > > \_SB.PCI0.CIO2.port@1.endpoint@0 > > > > > > > > > > > > where the nodes are separated by a dot (".") and the first three are > > > > > > ACPI device nodes and the latter two ACPI data nodes. > > > > > > > > > > Do we support swnode here? > > > > > > > > Good question. The swnodes have no hierarchy at the moment (they're only > > > > created for a struct device as a parent) and they do not have human-readable > > > > names. So I'd say it's not relevant right now. Should these two change, > > > > support for swnode could (and should) be added later on. > > > > > > Heikki, what do you think about this? > > > > Well, the swnodes do have hierarchy. That was kind of the whole point > > of introducing them. They now can also be named using "name" property. > > See commit 344798206f171c5abea7ab1f9762fa526d7f539d. > > Right; I saw the function after initially replying to Andy but I missed > where the node name came from. :-) Now I know... > > I can add support for swnode, too, if you like. It's up to you. thanks, -- heikki