* [PATCH] USB/xHCI: Remove returned value 'status' since never used
@ 2019-03-26 20:15 Mathieu Malaterre
2019-03-27 11:21 ` Mukesh Ojha
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Mathieu Malaterre @ 2019-03-26 20:15 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: trivial, Mathieu Malaterre, Sarah Sharp, linux-usb, linux-kernel
The returned value in status has never been used since
commit 4296c70a5ec3 ("USB/xHCI: Enable USB 3.0 hub remote wakeup.")
So remove 'status' completely.
Remove warning (W=1):
drivers/usb/core/hub.c:3671:8: warning: variable 'status' set but not used [-Wunused-but-set-variable]
Cc: Sarah Sharp <sarah.a.sharp@intel.com>
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
drivers/usb/core/hub.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 8d4631c81b9f..15a2934dc29d 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -3668,7 +3668,6 @@ static int hub_suspend(struct usb_interface *intf, pm_message_t msg)
struct usb_hub *hub = usb_get_intfdata(intf);
struct usb_device *hdev = hub->hdev;
unsigned port1;
- int status;
/*
* Warn if children aren't already suspended.
@@ -3702,12 +3701,12 @@ static int hub_suspend(struct usb_interface *intf, pm_message_t msg)
if (hub_is_superspeed(hdev) && hdev->do_remote_wakeup) {
/* Enable hub to send remote wakeup for all ports. */
for (port1 = 1; port1 <= hdev->maxchild; port1++) {
- status = set_port_feature(hdev,
- port1 |
- USB_PORT_FEAT_REMOTE_WAKE_CONNECT |
- USB_PORT_FEAT_REMOTE_WAKE_DISCONNECT |
- USB_PORT_FEAT_REMOTE_WAKE_OVER_CURRENT,
- USB_PORT_FEAT_REMOTE_WAKE_MASK);
+ set_port_feature(hdev,
+ port1 |
+ USB_PORT_FEAT_REMOTE_WAKE_CONNECT |
+ USB_PORT_FEAT_REMOTE_WAKE_DISCONNECT |
+ USB_PORT_FEAT_REMOTE_WAKE_OVER_CURRENT,
+ USB_PORT_FEAT_REMOTE_WAKE_MASK);
}
}
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] USB/xHCI: Remove returned value 'status' since never used
2019-03-26 20:15 [PATCH] USB/xHCI: Remove returned value 'status' since never used Mathieu Malaterre
@ 2019-03-27 11:21 ` Mukesh Ojha
2019-03-27 15:02 ` Greg Kroah-Hartman
2019-03-27 19:40 ` [PATCH v2] USB: hub: " Mathieu Malaterre
2 siblings, 0 replies; 4+ messages in thread
From: Mukesh Ojha @ 2019-03-27 11:21 UTC (permalink / raw)
To: Mathieu Malaterre, Greg Kroah-Hartman
Cc: trivial, Sarah Sharp, linux-usb, linux-kernel
On 3/27/2019 1:45 AM, Mathieu Malaterre wrote:
> The returned value in status has never been used since
> commit 4296c70a5ec3 ("USB/xHCI: Enable USB 3.0 hub remote wakeup.")
> So remove 'status' completely.
>
> Remove warning (W=1):
>
> drivers/usb/core/hub.c:3671:8: warning: variable 'status' set but not used [-Wunused-but-set-variable]
>
> Cc: Sarah Sharp <sarah.a.sharp@intel.com>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> drivers/usb/core/hub.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 8d4631c81b9f..15a2934dc29d 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -3668,7 +3668,6 @@ static int hub_suspend(struct usb_interface *intf, pm_message_t msg)
> struct usb_hub *hub = usb_get_intfdata(intf);
> struct usb_device *hdev = hub->hdev;
> unsigned port1;
> - int status;
>
> /*
> * Warn if children aren't already suspended.
> @@ -3702,12 +3701,12 @@ static int hub_suspend(struct usb_interface *intf, pm_message_t msg)
> if (hub_is_superspeed(hdev) && hdev->do_remote_wakeup) {
> /* Enable hub to send remote wakeup for all ports. */
> for (port1 = 1; port1 <= hdev->maxchild; port1++) {
> - status = set_port_feature(hdev,
> - port1 |
> - USB_PORT_FEAT_REMOTE_WAKE_CONNECT |
> - USB_PORT_FEAT_REMOTE_WAKE_DISCONNECT |
> - USB_PORT_FEAT_REMOTE_WAKE_OVER_CURRENT,
> - USB_PORT_FEAT_REMOTE_WAKE_MASK);
should not we check return value instead of removing it.
Thanks,
Mukesh
> + set_port_feature(hdev,
> + port1 |
> + USB_PORT_FEAT_REMOTE_WAKE_CONNECT |
> + USB_PORT_FEAT_REMOTE_WAKE_DISCONNECT |
> + USB_PORT_FEAT_REMOTE_WAKE_OVER_CURRENT,
> + USB_PORT_FEAT_REMOTE_WAKE_MASK);
> }
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] USB/xHCI: Remove returned value 'status' since never used
2019-03-26 20:15 [PATCH] USB/xHCI: Remove returned value 'status' since never used Mathieu Malaterre
2019-03-27 11:21 ` Mukesh Ojha
@ 2019-03-27 15:02 ` Greg Kroah-Hartman
2019-03-27 19:40 ` [PATCH v2] USB: hub: " Mathieu Malaterre
2 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2019-03-27 15:02 UTC (permalink / raw)
To: Mathieu Malaterre; +Cc: trivial, Sarah Sharp, linux-usb, linux-kernel
On Tue, Mar 26, 2019 at 09:15:57PM +0100, Mathieu Malaterre wrote:
> The returned value in status has never been used since
> commit 4296c70a5ec3 ("USB/xHCI: Enable USB 3.0 hub remote wakeup.")
> So remove 'status' completely.
>
> Remove warning (W=1):
>
> drivers/usb/core/hub.c:3671:8: warning: variable 'status' set but not used [-Wunused-but-set-variable]
>
> Cc: Sarah Sharp <sarah.a.sharp@intel.com>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> drivers/usb/core/hub.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
Why do you have xhci in your subject line? Shouldn't it be "USB: hub:"?
Please fix up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] USB: hub: Remove returned value 'status' since never used
2019-03-26 20:15 [PATCH] USB/xHCI: Remove returned value 'status' since never used Mathieu Malaterre
2019-03-27 11:21 ` Mukesh Ojha
2019-03-27 15:02 ` Greg Kroah-Hartman
@ 2019-03-27 19:40 ` Mathieu Malaterre
2 siblings, 0 replies; 4+ messages in thread
From: Mathieu Malaterre @ 2019-03-27 19:40 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Mathieu Malaterre, linux-usb, linux-kernel
The returned value in status has never been used since
commit 4296c70a5ec3 ("USB/xHCI: Enable USB 3.0 hub remote wakeup.")
So remove 'status' completely.
Remove warning (W=1):
drivers/usb/core/hub.c:3671:8: warning: variable 'status' set but not used [-Wunused-but-set-variable]
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
v2: change subject prefix from USB/xHCI: to USB: hub:
drivers/usb/core/hub.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 8d4631c81b9f..15a2934dc29d 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -3668,7 +3668,6 @@ static int hub_suspend(struct usb_interface *intf, pm_message_t msg)
struct usb_hub *hub = usb_get_intfdata(intf);
struct usb_device *hdev = hub->hdev;
unsigned port1;
- int status;
/*
* Warn if children aren't already suspended.
@@ -3702,12 +3701,12 @@ static int hub_suspend(struct usb_interface *intf, pm_message_t msg)
if (hub_is_superspeed(hdev) && hdev->do_remote_wakeup) {
/* Enable hub to send remote wakeup for all ports. */
for (port1 = 1; port1 <= hdev->maxchild; port1++) {
- status = set_port_feature(hdev,
- port1 |
- USB_PORT_FEAT_REMOTE_WAKE_CONNECT |
- USB_PORT_FEAT_REMOTE_WAKE_DISCONNECT |
- USB_PORT_FEAT_REMOTE_WAKE_OVER_CURRENT,
- USB_PORT_FEAT_REMOTE_WAKE_MASK);
+ set_port_feature(hdev,
+ port1 |
+ USB_PORT_FEAT_REMOTE_WAKE_CONNECT |
+ USB_PORT_FEAT_REMOTE_WAKE_DISCONNECT |
+ USB_PORT_FEAT_REMOTE_WAKE_OVER_CURRENT,
+ USB_PORT_FEAT_REMOTE_WAKE_MASK);
}
}
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-27 19:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-26 20:15 [PATCH] USB/xHCI: Remove returned value 'status' since never used Mathieu Malaterre
2019-03-27 11:21 ` Mukesh Ojha
2019-03-27 15:02 ` Greg Kroah-Hartman
2019-03-27 19:40 ` [PATCH v2] USB: hub: " Mathieu Malaterre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox