Re: [PATCH 13/25] coresight: etb10: Clean up device specific data

Suzuki K Poulose
2019-03-28T11:07:03Z

On 03/27/2019 09:39 PM, Mathieu Poirier wrote:
> On Wed, Mar 20, 2019 at 06:49:30PM +0000, Suzuki K Poulose wrote:
>> Track the coresight device instead of the real device.
>>
>> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>

>>
>> @@ -701,7 +701,6 @@ static int etb_probe(struct amba_device *adev, const struct amba_id *id)
>> if (!drvdata)
>> return -ENOMEM;
>>
>> - drvdata->dev = &adev->dev;
>> drvdata->atclk = devm_clk_get(&adev->dev, "atclk"); /* optional */
>> if (!IS_ERR(drvdata->atclk)) {
>> ret = clk_prepare_enable(drvdata->atclk);
>> @@ -740,6 +739,7 @@ static int etb_probe(struct amba_device *adev, const struct amba_id *id)
>> if (IS_ERR(drvdata->csdev))
>> return PTR_ERR(drvdata->csdev);
>>
>> + drvdata->dev = &drvdata->csdev->dev;
>
> For patch 11, 12, 13 - same comment as earlier. Let's use drvdata::csdev
> and get rid of drvdata::dev.
>

Sure, will do.

Thanks for the detailed review !

Suzuki