Re: [PATCH AUTOSEL 5.0 107/262] ASoC: qcom: Fix of-node refcount unbalance in apq8016_sbc_parse_of()

Mark Brown
2019-03-27T19:31:26Z

[-- Attachment #1: Type: text/plain, Size: 890 bytes --]

On Wed, Mar 27, 2019 at 01:59:22PM -0400, Sasha Levin wrote:
> From: Takashi Iwai <tiwai@suse.de>
>
> [ Upstream commit 8d1667200850f8753c0265fa4bd25c9a6e5f94ce ]
>
> The apq8016 driver leaves the of-node refcount at aborting from the
> loop of for_each_child_of_node() in the error path. Not only the
> iterator node of for_each_child_of_node(), the children nodes referred
> from it for codec and cpu have to be properly unreferenced.

Given that the device tree is entirely static on all platforms using FDT
I'm not convinced that it is sensible to backport any of the fixes for
references not being dropped that are more than one liners,
realistically nothing is ever going to notice the extra references but
there are things that will notice if we underflow references so there's
some risk we could break things somehow. Seems like it's all risk for
zero benefit.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]