From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FDFEC43381 for ; Wed, 27 Mar 2019 18:35:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 26B3020657 for ; Wed, 27 Mar 2019 18:35:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553711716; bh=qUpKSpkOlmi2VkEic6poulyBp84gUtWWBEjZQBMPOlk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jaQGN/kHV45RoPM/ukOy8N9IyqCTC2CdlohnxtI9o3BZbiCjvK13dpA/HTeIrr0j4 Pkb3KfuxxLQNSFELl3DMRWc+MHo+7H42CT7GggN0OV9rUH4mzmGwTzGb+52Xu6dRlx oC+y++vCC542CF6X+Fz1Q9DyacNJkOtNLVU1WH8s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404171AbfC0SfO (ORCPT ); Wed, 27 Mar 2019 14:35:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:43512 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404007AbfC0SYg (ORCPT ); Wed, 27 Mar 2019 14:24:36 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2A4D020449; Wed, 27 Mar 2019 18:24:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553711075; bh=qUpKSpkOlmi2VkEic6poulyBp84gUtWWBEjZQBMPOlk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lCh2ADmGlACEQNyMGkkYfLpLHw2Xc+xALpuixZwvTcaweIWYOXb6bVF+Om6nXIZZ4 z3lkRfqZECWBJLGFjEOUaT7HFYSh7STf/5MZKKGI61vwzB3nzNOPD5r+5glk+KJDfW rOgZX17i9iLO0nfipkDX0CS0xXIir4HQWtjbEhrg= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Coly Li , Jens Axboe , Sasha Levin , linux-bcache@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 40/63] bcache: fix input overflow to sequential_cutoff Date: Wed, 27 Mar 2019 14:23:00 -0400 Message-Id: <20190327182323.18577-40-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190327182323.18577-1-sashal@kernel.org> References: <20190327182323.18577-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Coly Li [ Upstream commit 8c27a3953e92eb0b22dbb03d599f543a05f9574e ] People may set sequential_cutoff of a cached device via sysfs file, but current code does not check input value overflow. E.g. if value 4294967295 (UINT_MAX) is written to file sequential_cutoff, its value is 4GB, but if 4294967296 (UINT_MAX + 1) is written into, its value will be 0. This is an unexpected behavior. This patch replaces d_strtoi_h() by sysfs_strtoul_clamp() to convert input string to unsigned integer value, and limit its range in [0, UINT_MAX]. Then the input overflow can be fixed. Signed-off-by: Coly Li Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/md/bcache/sysfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c index 87daccbbc61b..463ce6757338 100644 --- a/drivers/md/bcache/sysfs.c +++ b/drivers/md/bcache/sysfs.c @@ -215,7 +215,9 @@ STORE(__cached_dev) d_strtoul(writeback_rate_d_term); d_strtoul_nonzero(writeback_rate_p_term_inverse); - d_strtoi_h(sequential_cutoff); + sysfs_strtoul_clamp(sequential_cutoff, + dc->sequential_cutoff, + 0, UINT_MAX); d_strtoi_h(readahead); if (attr == &sysfs_clear_stats) -- 2.19.1