Re: [PATCH 4/6] x86, mm: make split_mem_range() more easy to read

Wei Yang
2019-03-29T03:38:27Z

On Thu, Mar 28, 2019 at 09:08:43AM +0100, Thomas Gleixner wrote:
>On Thu, 28 Mar 2019, Wei Yang wrote:
>> On Sun, Mar 24, 2019 at 03:29:04PM +0100, Thomas Gleixner wrote:
>> My question is to the for loop.
>>
>> For example, we have a range
>>
>> +--+---------+-----------------------+
>> ^ 128M 1G 2G
>> 128M - 4K
>>
>
>Yes. You misread mr_try_map().

You are right, I misunderstand the functionality of mr_try_map().

I went through the code and this looks nice to me. I have to say you are
genius.

Thanks for your code and I really learned a lot from this.

BTW, for the test cases, I thinks mem-hotplug may be introduce layout
diversity. Since mem-hotplug's range has to be 128M aligned.

>
>Thanks,
>
> tglx

--
Wei Yang
Help you, Help me