From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 187C5C43381 for ; Thu, 28 Mar 2019 13:39:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DBAF220823 for ; Thu, 28 Mar 2019 13:39:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="Bl6PgPm9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727623AbfC1Nj0 (ORCPT ); Thu, 28 Mar 2019 09:39:26 -0400 Received: from mail.skyhub.de ([5.9.137.197]:58854 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727275AbfC1NjC (ORCPT ); Thu, 28 Mar 2019 09:39:02 -0400 Received: from zn.tnic (p200300EC2F098000329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2f09:8000:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D0A501EC0985; Thu, 28 Mar 2019 14:39:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1553780340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=YBlB0v+Rk04BC3L113uctbUpy5NUBaHaUzKGpUyyHoY=; b=Bl6PgPm9WQ3+npY0ILuwqO2UQKH+yY/5oHMagkJmWrIdGUpvZGv2aRqebcCV4pEMJetq4B K5tW8dYaGIHWHjO57B0qaAjGle9o1Vd3QLsgWE7oo5br3JhAsCwPh6qzfMyVLbWIt1hcJw fCCBbnC3dXws2+bbTif5CffQXEJmnl4= Date: Thu, 28 Mar 2019 14:39:07 +0100 From: Borislav Petkov To: Andy Shevchenko Cc: Joe Perches , "H. Peter Anvin" , x86@kernel.org, Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/7] x86/boot: Split out parse_serial_port() helper for earlyprintk Message-ID: <20190328133907.GI22720@zn.tnic> References: <20190319184325.72807-1-andriy.shevchenko@linux.intel.com> <20190319184325.72807-4-andriy.shevchenko@linux.intel.com> <20190328123504.GF22720@zn.tnic> <20190328131557.GY9224@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190328131557.GY9224@smile.fi.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 28, 2019 at 03:15:57PM +0200, Andy Shevchenko wrote: > kstrtox() simple can't cover _all_ simple_strtox() cases. I see only one case here. Are you saying kstrtoull() cannot work here? > I don't feel like uglifying code to satisfy a tool producing a silly warning. Uglifying how? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.