From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Joe Perches <joe@perches.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/7] x86/boot: Split out parse_serial_port() helper for earlyprintk
Date: Thu, 28 Mar 2019 15:50:15 +0200 [thread overview]
Message-ID: <20190328135015.GA9224@smile.fi.intel.com> (raw)
In-Reply-To: <20190328133907.GI22720@zn.tnic>
On Thu, Mar 28, 2019 at 02:39:07PM +0100, Borislav Petkov wrote:
> On Thu, Mar 28, 2019 at 03:15:57PM +0200, Andy Shevchenko wrote:
> > kstrtox() simple can't cover _all_ simple_strtox() cases.
>
> I see only one case here. Are you saying kstrtoull() cannot work
> here?
Can, but with code uglifying to workaround kstrtox() restrictions.
simple_strtox() _just works_ as expected.
> > I don't feel like uglifying code to satisfy a tool producing a silly
> warning.
>
> Uglifying how?
Requires buffer copying, finding digits there, making a proper termination. And
basically dropping the error check, because we don't care at this stage about
wrong input.
And we didn't start to talk about possible user expectation breakage and
basically breakage weird user cases.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-03-28 13:50 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 18:43 [PATCH v2 0/7] x86/boot: Enable earlyprintk for HS UARTs Andy Shevchenko
2019-03-19 18:43 ` [PATCH v2 1/7] x86/boot: Convert early_serial_base to unsigned long Andy Shevchenko
2019-03-28 8:28 ` Borislav Petkov
2019-03-28 9:09 ` Andy Shevchenko
2019-03-28 10:54 ` Borislav Petkov
2019-03-19 18:43 ` [PATCH v2 2/7] x86/boot: Introduce helpers for serial I/O Andy Shevchenko
2019-03-28 12:32 ` Borislav Petkov
2019-03-28 13:11 ` Andy Shevchenko
2019-03-28 13:28 ` Borislav Petkov
2019-03-28 13:52 ` Andy Shevchenko
2019-03-28 14:05 ` Borislav Petkov
2019-03-28 14:20 ` Andy Shevchenko
2019-03-28 14:34 ` Borislav Petkov
2019-03-28 14:51 ` Andy Shevchenko
2019-03-19 18:43 ` [PATCH v2 3/7] x86/boot: Split out parse_serial_port() helper for earlyprintk Andy Shevchenko
2019-03-28 12:35 ` Borislav Petkov
2019-03-28 13:15 ` Andy Shevchenko
2019-03-28 13:39 ` Borislav Petkov
2019-03-28 13:50 ` Andy Shevchenko [this message]
2019-03-28 14:03 ` Borislav Petkov
2019-03-28 14:23 ` Andy Shevchenko
2019-03-28 14:35 ` Borislav Petkov
2019-03-28 14:49 ` Andy Shevchenko
2019-03-19 18:43 ` [PATCH v2 4/7] x86/boot: Allow longer parameter list " Andy Shevchenko
2019-03-19 18:43 ` [PATCH v2 5/7] x86/boot: Add MMIO byte accessors Andy Shevchenko
2019-03-19 18:43 ` [PATCH v2 6/7] x86/boot: Introduce MMIO accessors and their support in earlyprintk Andy Shevchenko
2019-03-19 18:43 ` [PATCH v2 7/7] x86/boot: Support nocfg parameter for earlyprintk Andy Shevchenko
2019-03-20 15:05 ` Randy Dunlap
2019-03-20 15:17 ` Andy Shevchenko
2019-03-20 15:19 ` Randy Dunlap
2019-03-20 16:15 ` Andy Shevchenko
2019-03-20 16:30 ` Borislav Petkov
2019-03-20 17:29 ` Andy Shevchenko
2019-03-28 13:03 ` Borislav Petkov
2019-03-28 13:21 ` Andy Shevchenko
2019-03-28 13:42 ` Borislav Petkov
2019-03-28 14:00 ` Andy Shevchenko
2019-03-28 14:13 ` Borislav Petkov
2019-03-28 14:27 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328135015.GA9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox