From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6E54C43381 for ; Thu, 28 Mar 2019 13:50:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD95B20823 for ; Thu, 28 Mar 2019 13:50:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726338AbfC1NuU (ORCPT ); Thu, 28 Mar 2019 09:50:20 -0400 Received: from mga02.intel.com ([134.134.136.20]:27167 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725816AbfC1NuT (ORCPT ); Thu, 28 Mar 2019 09:50:19 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2019 06:50:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,280,1549958400"; d="scan'208";a="135555022" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by fmsmga008.fm.intel.com with ESMTP; 28 Mar 2019 06:50:16 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1h9VQ7-00033b-5Q; Thu, 28 Mar 2019 15:50:15 +0200 Date: Thu, 28 Mar 2019 15:50:15 +0200 From: Andy Shevchenko To: Borislav Petkov Cc: Joe Perches , "H. Peter Anvin" , x86@kernel.org, Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/7] x86/boot: Split out parse_serial_port() helper for earlyprintk Message-ID: <20190328135015.GA9224@smile.fi.intel.com> References: <20190319184325.72807-1-andriy.shevchenko@linux.intel.com> <20190319184325.72807-4-andriy.shevchenko@linux.intel.com> <20190328123504.GF22720@zn.tnic> <20190328131557.GY9224@smile.fi.intel.com> <20190328133907.GI22720@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190328133907.GI22720@zn.tnic> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 28, 2019 at 02:39:07PM +0100, Borislav Petkov wrote: > On Thu, Mar 28, 2019 at 03:15:57PM +0200, Andy Shevchenko wrote: > > kstrtox() simple can't cover _all_ simple_strtox() cases. > > I see only one case here. Are you saying kstrtoull() cannot work > here? Can, but with code uglifying to workaround kstrtox() restrictions. simple_strtox() _just works_ as expected. > > I don't feel like uglifying code to satisfy a tool producing a silly > warning. > > Uglifying how? Requires buffer copying, finding digits there, making a proper termination. And basically dropping the error check, because we don't care at this stage about wrong input. And we didn't start to talk about possible user expectation breakage and basically breakage weird user cases. -- With Best Regards, Andy Shevchenko