From: Rob Herring <robh@kernel.org>
To: Gregory CLEMENT <gregory.clement@bootlin.com>
Cc: "Stephen Boyd" <sboyd@codeaurora.org>,
"Mike Turquette" <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, "Jason Cooper" <jason@lakedaemon.net>,
"Andrew Lunn" <andrew@lunn.ch>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
"Antoine Tenart" <antoine.tenart@bootlin.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH v4 1/6] dt-bindings: ap806: add the cluster clock node in the syscon file
Date: Thu, 28 Mar 2019 12:39:24 -0500 [thread overview]
Message-ID: <20190328173924.GB26680@bogus> (raw)
In-Reply-To: <87k1gioqrp.fsf@FE-laptop>
On Thu, Mar 28, 2019 at 06:25:14PM +0100, Gregory CLEMENT wrote:
> Hi Rob,
>
> On jeu., mars 28 2019, Rob Herring <robh@kernel.org> wrote:
>
> > On Mon, Mar 25, 2019 at 01:47:58PM +0100, Gregory CLEMENT wrote:
> >> Document the device tree binding for the cluster clock controllers found
> >> in the Armada 7K/8K SoCs.
> >>
> >> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> >> ---
> >> .../arm/marvell/ap806-system-controller.txt | 25 +++++++++++++++++++
> >> 1 file changed, 25 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt b/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt
> >> index 7b8b8eb0191f..ceeba18b4ac3 100644
> >> --- a/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt
> >> +++ b/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt
> >> @@ -143,3 +143,28 @@ ap_syscon1: system-controller@6f8000 {
> >> #thermal-sensor-cells = <1>;
> >> };
> >> };
> >> +
> >> +Cluster clocks:
> >> +---------------
> >> +
> >> +Device Tree Clock bindings for cluster clock of AP806 Marvell. Each
> >> +cluster contain up to 2 CPUs running at the same frequency.
> >> +
> >> +Required properties:
> >> +- compatible: must be "marvell,ap806-cpu-clock";
> >> +- #clock-cells : should be set to 1.
> >> +- clocks : shall be the input parents clock phandle for the clock.
> >> +
> >> +Optional property:
> >> + - reg: register range associated the cluser clocks
> >
> > reg can be optional to use, but should either be there or not.
>
> OK so let's remove it!
If you can define what the registers are, then you should have it even
if Linux happens to not care.
Rob
next prev parent reply other threads:[~2019-03-28 17:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 12:47 [PATCH v4 0/6] Add CPU clock support for Armada 7K/8K Gregory CLEMENT
2019-03-25 12:47 ` [PATCH v4 1/6] dt-bindings: ap806: add the cluster clock node in the syscon file Gregory CLEMENT
2019-03-28 17:13 ` Rob Herring
2019-03-28 17:25 ` Gregory CLEMENT
2019-03-28 17:39 ` Rob Herring [this message]
2019-03-25 12:47 ` [PATCH v4 2/6] clk: mvebu: add helper file for Armada AP and CP clocks Gregory CLEMENT
2019-03-25 12:48 ` [PATCH v4 3/6] clk: mvebu: add CPU clock driver for Armada 7K/8K Gregory CLEMENT
2019-03-25 12:48 ` [PATCH v4 4/6] clk: mvebu: ap806: Fix clock name for the cluster Gregory CLEMENT
2019-03-25 12:48 ` [PATCH v4 5/6] arm64: marvell: enable the Armada 7K/8K CPU clk driver Gregory CLEMENT
2019-03-25 12:48 ` [PATCH v4 6/6] arm64: dts: marvell: Add cpu clock node on Armada 7K/8K Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328173924.GB26680@bogus \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox