From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14EEFC43381 for ; Thu, 28 Mar 2019 21:21:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D80B621850 for ; Thu, 28 Mar 2019 21:21:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727176AbfC1VVu (ORCPT ); Thu, 28 Mar 2019 17:21:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38966 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726250AbfC1VVu (ORCPT ); Thu, 28 Mar 2019 17:21:50 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6F9B58046F; Thu, 28 Mar 2019 21:21:49 +0000 (UTC) Received: from redhat.com (ovpn-121-118.rdu2.redhat.com [10.10.121.118]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 518825C226; Thu, 28 Mar 2019 21:21:48 +0000 (UTC) Date: Thu, 28 Mar 2019 17:21:46 -0400 From: Jerome Glisse To: John Hubbard Cc: Ira Weiny , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Dan Williams Subject: Re: [PATCH v2 02/11] mm/hmm: use reference counting for HMM struct v2 Message-ID: <20190328212145.GA13560@redhat.com> References: <20190325144011.10560-1-jglisse@redhat.com> <20190325144011.10560-3-jglisse@redhat.com> <20190328110719.GA31324@iweiny-DESK2.sc.intel.com> <20190328191122.GA5740@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 28 Mar 2019 21:21:49 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 28, 2019 at 01:43:13PM -0700, John Hubbard wrote: > On 3/28/19 12:11 PM, Jerome Glisse wrote: > > On Thu, Mar 28, 2019 at 04:07:20AM -0700, Ira Weiny wrote: > >> On Mon, Mar 25, 2019 at 10:40:02AM -0400, Jerome Glisse wrote: > >>> From: Jérôme Glisse > >>> > >>> Every time i read the code to check that the HMM structure does not > >>> vanish before it should thanks to the many lock protecting its removal > >>> i get a headache. Switch to reference counting instead it is much > >>> easier to follow and harder to break. This also remove some code that > >>> is no longer needed with refcounting. > >>> > >>> Changes since v1: > >>> - removed bunch of useless check (if API is use with bogus argument > >>> better to fail loudly so user fix their code) > >>> - s/hmm_get/mm_get_hmm/ > >>> > >>> Signed-off-by: Jérôme Glisse > >>> Reviewed-by: Ralph Campbell > >>> Cc: John Hubbard > >>> Cc: Andrew Morton > >>> Cc: Dan Williams > >>> --- > >>> include/linux/hmm.h | 2 + > >>> mm/hmm.c | 170 ++++++++++++++++++++++++++++---------------- > >>> 2 files changed, 112 insertions(+), 60 deletions(-) > >>> > >>> diff --git a/include/linux/hmm.h b/include/linux/hmm.h > >>> index ad50b7b4f141..716fc61fa6d4 100644 > >>> --- a/include/linux/hmm.h > >>> +++ b/include/linux/hmm.h > >>> @@ -131,6 +131,7 @@ enum hmm_pfn_value_e { > >>> /* > >>> * struct hmm_range - track invalidation lock on virtual address range > >>> * > >>> + * @hmm: the core HMM structure this range is active against > >>> * @vma: the vm area struct for the range > >>> * @list: all range lock are on a list > >>> * @start: range virtual start address (inclusive) > >>> @@ -142,6 +143,7 @@ enum hmm_pfn_value_e { > >>> * @valid: pfns array did not change since it has been fill by an HMM function > >>> */ > >>> struct hmm_range { > >>> + struct hmm *hmm; > >>> struct vm_area_struct *vma; > >>> struct list_head list; > >>> unsigned long start; > >>> diff --git a/mm/hmm.c b/mm/hmm.c > >>> index fe1cd87e49ac..306e57f7cded 100644 > >>> --- a/mm/hmm.c > >>> +++ b/mm/hmm.c > >>> @@ -50,6 +50,7 @@ static const struct mmu_notifier_ops hmm_mmu_notifier_ops; > >>> */ > >>> struct hmm { > >>> struct mm_struct *mm; > >>> + struct kref kref; > >>> spinlock_t lock; > >>> struct list_head ranges; > >>> struct list_head mirrors; > >>> @@ -57,6 +58,16 @@ struct hmm { > >>> struct rw_semaphore mirrors_sem; > >>> }; > >>> > >>> +static inline struct hmm *mm_get_hmm(struct mm_struct *mm) > >>> +{ > >>> + struct hmm *hmm = READ_ONCE(mm->hmm); > >>> + > >>> + if (hmm && kref_get_unless_zero(&hmm->kref)) > >>> + return hmm; > >>> + > >>> + return NULL; > >>> +} > >>> + > >>> /* > >>> * hmm_register - register HMM against an mm (HMM internal) > >>> * > >>> @@ -67,14 +78,9 @@ struct hmm { > >>> */ > >>> static struct hmm *hmm_register(struct mm_struct *mm) > >>> { > >>> - struct hmm *hmm = READ_ONCE(mm->hmm); > >>> + struct hmm *hmm = mm_get_hmm(mm); > >> > >> FWIW: having hmm_register == "hmm get" is a bit confusing... > > > > The thing is that you want only one hmm struct per process and thus > > if there is already one and it is not being destroy then you want to > > reuse it. > > > > Also this is all internal to HMM code and so it should not confuse > > anyone. > > > > Well, it has repeatedly come up, and I'd claim that it is quite > counter-intuitive. So if there is an easy way to make this internal > HMM code clearer or better named, I would really love that to happen. > > And we shouldn't ever dismiss feedback based on "this is just internal > xxx subsystem code, no need for it to be as clear as other parts of the > kernel", right? Yes but i have not seen any better alternative that present code. If there is please submit patch. Cheers, Jérôme