public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: vf610-zii-cfu1: Disable NOR flash/SPI controller
@ 2019-03-25 18:30 Andrey Smirnov
  2019-03-29  3:25 ` Shawn Guo
  0 siblings, 1 reply; 2+ messages in thread
From: Andrey Smirnov @ 2019-03-25 18:30 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Andrey Smirnov, Chris Healy, Andrew Lunn, Fabio Estevam,
	linux-arm-kernel, linux-kernel

Only a certain number of CFU1's come with NOR flash populated. Disable
it by default to avoid trying to probe NOR flash on devices that don't
have it. Devices that do have it can rely on the bootloader to enable
this node.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
 arch/arm/boot/dts/vf610-zii-cfu1.dts | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/vf610-zii-cfu1.dts b/arch/arm/boot/dts/vf610-zii-cfu1.dts
index 6c78122401a1..afc25b33bd3b 100644
--- a/arch/arm/boot/dts/vf610-zii-cfu1.dts
+++ b/arch/arm/boot/dts/vf610-zii-cfu1.dts
@@ -87,7 +87,12 @@
 	bus-num = <1>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_dspi1>;
-	status = "okay";
+	/*
+	 * Some CFU1s come with SPI-NOR chip DNPed, so we leave this
+	 * node disabled by default and rely on bootloader to enable
+	 * it when appropriate.
+	 */
+	status = "disabled";
 
 	m25p128@0 {
 		#address-cells = <1>;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: vf610-zii-cfu1: Disable NOR flash/SPI controller
  2019-03-25 18:30 [PATCH] ARM: dts: vf610-zii-cfu1: Disable NOR flash/SPI controller Andrey Smirnov
@ 2019-03-29  3:25 ` Shawn Guo
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2019-03-29  3:25 UTC (permalink / raw)
  To: Andrey Smirnov
  Cc: Chris Healy, Andrew Lunn, Fabio Estevam, linux-arm-kernel,
	linux-kernel

On Mon, Mar 25, 2019 at 11:30:17AM -0700, Andrey Smirnov wrote:
> Only a certain number of CFU1's come with NOR flash populated. Disable
> it by default to avoid trying to probe NOR flash on devices that don't
> have it. Devices that do have it can rely on the bootloader to enable
> this node.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-29  3:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-25 18:30 [PATCH] ARM: dts: vf610-zii-cfu1: Disable NOR flash/SPI controller Andrey Smirnov
2019-03-29  3:25 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox