From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E818C43381 for ; Fri, 29 Mar 2019 06:44:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DBEB62082F for ; Fri, 29 Mar 2019 06:44:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728783AbfC2God (ORCPT ); Fri, 29 Mar 2019 02:44:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38244 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728715AbfC2God (ORCPT ); Fri, 29 Mar 2019 02:44:33 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DB1F3307D848; Fri, 29 Mar 2019 06:44:32 +0000 (UTC) Received: from localhost (ovpn-12-24.pek2.redhat.com [10.72.12.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 060131001E8F; Fri, 29 Mar 2019 06:44:31 +0000 (UTC) Date: Fri, 29 Mar 2019 14:44:29 +0800 From: Baoquan He To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@suse.com, rppt@linux.ibm.com, osalvador@suse.de, willy@infradead.org, william.kucharski@oracle.com Subject: Re: [PATCH v2 0/4] Clean up comments and codes in sparse_add_one_section() Message-ID: <20190329064429.GB7627@MiWiFi-R3L-srv> References: <20190326090227.3059-1-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190326090227.3059-1-bhe@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Fri, 29 Mar 2019 06:44:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Talked to Michal, the local code refactorying may impact those big feature or improvement patchset, e.g patch 2/4 and patch 3/4 will conflict with Dan's patchset: [PATCH v5 00/10] mm: Sub-section memory hotplug support So I would like to discard them and only repost patch 1/4 and 4/4 after addressing reviewers' concern. Sorry for the noise. On 03/26/19 at 05:02pm, Baoquan He wrote: > This is v2 post. V1 is here: > http://lkml.kernel.org/r/20190320073540.12866-1-bhe@redhat.com > > This patchset includes 4 patches. The first three patches are around > sparse_add_one_section(). The last one is a simple clean up patch when > review codes in hotplug path, carry it in this patchset. > > Baoquan He (4): > mm/sparse: Clean up the obsolete code comment > mm/sparse: Optimize sparse_add_one_section() > mm/sparse: Rename function related to section memmap allocation/free > drivers/base/memory.c: Rename the misleading parameter > > drivers/base/memory.c | 6 ++--- > mm/sparse.c | 58 ++++++++++++++++++++++--------------------- > 2 files changed, 33 insertions(+), 31 deletions(-) > > -- > 2.17.2 >