From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA39AC43381 for ; Fri, 29 Mar 2019 09:19:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 910BB2173C for ; Fri, 29 Mar 2019 09:19:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728860AbfC2JTj (ORCPT ); Fri, 29 Mar 2019 05:19:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42436 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728676AbfC2JTi (ORCPT ); Fri, 29 Mar 2019 05:19:38 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7FABD307CDED; Fri, 29 Mar 2019 09:19:38 +0000 (UTC) Received: from localhost (ovpn-12-24.pek2.redhat.com [10.72.12.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DC4521EE; Fri, 29 Mar 2019 09:19:37 +0000 (UTC) Date: Fri, 29 Mar 2019 17:19:35 +0800 From: Baoquan He To: Michal Hocko Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, rafael@kernel.org, akpm@linux-foundation.org, osalvador@suse.de, rppt@linux.ibm.com, willy@infradead.org, fanc.fnst@cn.fujitsu.com Subject: Re: [PATCH v3 2/2] drivers/base/memory.c: Rename the misleading parameter Message-ID: <20190329091935.GF7627@MiWiFi-R3L-srv> References: <20190329082915.19763-1-bhe@redhat.com> <20190329082915.19763-2-bhe@redhat.com> <20190329091325.GD28616@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190329091325.GD28616@dhcp22.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Fri, 29 Mar 2019 09:19:38 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/29/19 at 10:13am, Michal Hocko wrote: > On Fri 29-03-19 16:29:15, Baoquan He wrote: > > The input parameter 'phys_index' of memory_block_action() is actually > > the section number, but not the phys_index of memory_block. Fix it. > > I have tried to explain that the naming is mostly a relict from the past > than really a misleading name http://lkml.kernel.org/r/20190326093315.GL28406@dhcp22.suse.cz > Maybe it would be good to reflect that in the changelog > > > Signed-off-by: Baoquan He > > btw. I've acked the previous version as well. Sure, will rewrite the log and add people's Acked-by tag. Thanks. > > > --- > > v2->v3: > > Rename the parameter to 'start_section_nr' from 'sec'. > > > > drivers/base/memory.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c > > index cb8347500ce2..9ea972b2ae79 100644 > > --- a/drivers/base/memory.c > > +++ b/drivers/base/memory.c > > @@ -231,13 +231,14 @@ static bool pages_correctly_probed(unsigned long start_pfn) > > * OK to have direct references to sparsemem variables in here. > > */ > > static int > > -memory_block_action(unsigned long phys_index, unsigned long action, int online_type) > > +memory_block_action(unsigned long start_section_nr, unsigned long action, > > + int online_type) > > { > > unsigned long start_pfn; > > unsigned long nr_pages = PAGES_PER_SECTION * sections_per_block; > > int ret; > > > > - start_pfn = section_nr_to_pfn(phys_index); > > + start_pfn = section_nr_to_pfn(start_section_nr); > > > > switch (action) { > > case MEM_ONLINE: > > @@ -251,7 +252,7 @@ memory_block_action(unsigned long phys_index, unsigned long action, int online_t > > break; > > default: > > WARN(1, KERN_WARNING "%s(%ld, %ld) unknown action: " > > - "%ld\n", __func__, phys_index, action, action); > > + "%ld\n", __func__, start_section_nr, action, action); > > ret = -EINVAL; > > } > > > > -- > > 2.17.2 > > > > -- > Michal Hocko > SUSE Labs