From: Christoph Hellwig <hch@lst.de>
To: Maximilian Heyne <mheyne@amazon.de>
Cc: David Woodhouse <dwmw2@infradead.org>, Amit Shah <aams@amazon.de>,
Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] nvme: add per-device io and admin timeouts
Date: Fri, 29 Mar 2019 10:44:40 +0100 [thread overview]
Message-ID: <20190329094440.GA27315@lst.de> (raw)
In-Reply-To: <20190329093921.95710-1-mheyne@amazon.de>
On Fri, Mar 29, 2019 at 09:39:20AM +0000, Maximilian Heyne wrote:
> Some NVMe devices require specific io and admin timeouts that are
> different from the default, for instance local vs. remote storage.
>
> This patch adds per-device admin and io timeouts to the nvme_ctrl
> structure and replaces all usages of the module parameters in the PCI
> NVMe driver with the per-device timeouts.
I'm not all against a per-controller override, but if you controllers
really _require_ a different timeout this is not the way to go.
Please talk to the nvme technical working group about exposing a
default timeout in the controller as that is the only way to make
these things work out of box.
next prev parent reply other threads:[~2019-03-29 9:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 9:39 [PATCH 1/2] nvme: add per-device io and admin timeouts Maximilian Heyne
2019-03-29 9:39 ` [PATCH 2/2] nvme: add sysfs controls for " Maximilian Heyne
2019-03-29 9:44 ` Christoph Hellwig [this message]
2019-03-29 10:29 ` [PATCH 1/2] nvme: add per-device " David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329094440.GA27315@lst.de \
--to=hch@lst.de \
--cc=aams@amazon.de \
--cc=axboe@fb.com \
--cc=dwmw2@infradead.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mheyne@amazon.de \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox