* [RFC PATCH] drm/komeda: Creates plane alpha and blend mode properties
@ 2019-03-29 6:44 Lowry Li (Arm Technology China)
2019-03-29 16:25 ` Ayan Halder
0 siblings, 1 reply; 2+ messages in thread
From: Lowry Li (Arm Technology China) @ 2019-03-29 6:44 UTC (permalink / raw)
To: Liviu Dudau, james qian wang (Arm Technology China),
maarten.lankhorst@linux.intel.com, seanpaul@chromium.org,
airlied@linux.ie, Brian Starkey
Cc: Julien Yin (Arm Technology China),
Jonathan Chai (Arm Technology China), Ayan Halder,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nd
Creates plane alpha and blend mode properties attached to plane.
Signed-off-by: Lowry Li <lowry.li@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
index af51f0c..0ebec39 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
@@ -212,6 +212,17 @@ static int komeda_plane_add(struct komeda_kms_dev *kms,
drm_plane_helper_add(plane, &komeda_plane_helper_funcs);
+ err = drm_plane_create_alpha_property(plane);
+ if (err)
+ goto cleanup;
+
+ err = drm_plane_create_blend_mode_property(plane,
+ BIT(DRM_MODE_BLEND_PIXEL_NONE) |
+ BIT(DRM_MODE_BLEND_PREMULTI) |
+ BIT(DRM_MODE_BLEND_COVERAGE));
+ if (err)
+ goto cleanup;
+
return 0;
cleanup:
komeda_plane_destroy(plane);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC PATCH] drm/komeda: Creates plane alpha and blend mode properties
2019-03-29 6:44 [RFC PATCH] drm/komeda: Creates plane alpha and blend mode properties Lowry Li (Arm Technology China)
@ 2019-03-29 16:25 ` Ayan Halder
0 siblings, 0 replies; 2+ messages in thread
From: Ayan Halder @ 2019-03-29 16:25 UTC (permalink / raw)
To: Lowry Li (Arm Technology China)
Cc: Liviu Dudau, james qian wang (Arm Technology China),
maarten.lankhorst@linux.intel.com, seanpaul@chromium.org,
airlied@linux.ie, Brian Starkey,
Julien Yin (Arm Technology China),
Jonathan Chai (Arm Technology China),
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nd
On Fri, Mar 29, 2019 at 06:44:45AM +0000, Lowry Li (Arm Technology China) wrote:
> Creates plane alpha and blend mode properties attached to plane.
>
> Signed-off-by: Lowry Li <lowry.li@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> index af51f0c..0ebec39 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> @@ -212,6 +212,17 @@ static int komeda_plane_add(struct komeda_kms_dev *kms,
>
> drm_plane_helper_add(plane, &komeda_plane_helper_funcs);
>
> + err = drm_plane_create_alpha_property(plane);
> + if (err)
> + goto cleanup;
> +
> + err = drm_plane_create_blend_mode_property(plane,
> + BIT(DRM_MODE_BLEND_PIXEL_NONE) |
> + BIT(DRM_MODE_BLEND_PREMULTI) |
> + BIT(DRM_MODE_BLEND_COVERAGE));
> + if (err)
> + goto cleanup;
> +
> return 0;
> cleanup:
> komeda_plane_destroy(plane);
> --
Please rebase and test your patches on drm-misc-next.
https://drm.pages.freedesktop.org/maintainer-tools/repositories.html
> 1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-29 16:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-29 6:44 [RFC PATCH] drm/komeda: Creates plane alpha and blend mode properties Lowry Li (Arm Technology China)
2019-03-29 16:25 ` Ayan Halder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).