From: Corey Minyard <minyard@acm.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
cminyard@mvista.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tty/serial: Add a serial port simulator
Date: Fri, 29 Mar 2019 11:51:40 -0500 [thread overview]
Message-ID: <20190329165140.GD31733@minyard.net> (raw)
In-Reply-To: <447407be-0f49-f29d-6e81-bf4ed0a6e56b@zytor.com>
On Thu, Mar 28, 2019 at 12:39:12PM -0700, H. Peter Anvin wrote:
> Dumb question: this is basically a pty on steroids. Wouldn't this be
> better done by enhancing the pty devices?
I did look at that, but it would be pretty invasive to pty. There's
no modem control stuff, none of the other special serial ioctls. And
the locking in this driver is fairly strange because you have two
serial ports looking at each other's data for modem control. But
that might not be a big deal.
Adding the speed simulation to ptys would also be really strange.
That's not a deal-breaker, I suppose, but it's not much of a serial
port simulation without it.
-corey
next prev parent reply other threads:[~2019-03-29 16:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 17:12 [PATCH v2] tty/serial: Add a serial port simulator minyard
2019-03-05 23:29 ` Randy Dunlap
2019-03-06 1:51 ` Corey Minyard
2019-03-06 2:04 ` Randy Dunlap
2019-03-28 19:39 ` H. Peter Anvin
2019-03-29 16:51 ` Corey Minyard [this message]
2019-03-29 18:24 ` Grant Edwards
2019-03-27 15:44 ` Greg Kroah-Hartman
2019-03-29 22:13 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329165140.GD31733@minyard.net \
--to=minyard@acm.org \
--cc=cminyard@mvista.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox