From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51EF4C43381 for ; Sat, 30 Mar 2019 01:29:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 17D89218AC for ; Sat, 30 Mar 2019 01:29:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553909368; bh=PThzBADCX0C/qtnyMJHLAXilgCeKap49mscGIklJ5us=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2b+5aOJ2nuXl7+FY+4XuLKUF2LwKqaxeFeTFpJAqsbfpRKdsxap4rHu2Q7EELwNcz L/oPR9bvelLCu36ftGuSNjG/NCryrTLUU8arPgKaX8WC2bbgUKxeCxteV9TbJi9/Q1 DhsXf8kseag3D5JnGH78A9pYx9CXg9HIymNoedOk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730889AbfC3B3M (ORCPT ); Fri, 29 Mar 2019 21:29:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:35940 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730784AbfC3B3H (ORCPT ); Fri, 29 Mar 2019 21:29:07 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D66D0218FE; Sat, 30 Mar 2019 01:29:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553909346; bh=PThzBADCX0C/qtnyMJHLAXilgCeKap49mscGIklJ5us=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gNfErQpD9hddImFqdgUfJ4eG6M/pJvtbUK9JgbcQt6ChkNkYSVzBJKLofGZkCcJfJ yIkQdX6j8+dlNyEXTmrDo2M3Oghuft59A07lg/pIz4Qq35D7kcebbpmmuN9rCnEeru 8JZniFKnVzdvCKWGFsiQ6iB9KLjhUff6gBIo0Sto= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Michal Simek , Greg Kroah-Hartman , Sasha Levin , linux-serial@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 10/57] serial: uartps: console_setup() can't be placed to init section Date: Fri, 29 Mar 2019 21:28:03 -0400 Message-Id: <20190330012854.32212-10-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190330012854.32212-1-sashal@kernel.org> References: <20190330012854.32212-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Simek [ Upstream commit 4bb1ce2350a598502b23088b169e16b43d4bc639 ] When console device is rebinded, console_setup() is called again. But marking it as __init means that function will be clear after boot is complete. If console device is binded again console_setup() is not found and error "Unable to handle kernel paging request at virtual address" is reported. Signed-off-by: Michal Simek Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/xilinx_uartps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 0e3627289047..77efa0a43fe7 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1223,7 +1223,7 @@ static void cdns_uart_console_write(struct console *co, const char *s, * * Return: 0 on success, negative errno otherwise. */ -static int __init cdns_uart_console_setup(struct console *co, char *options) +static int cdns_uart_console_setup(struct console *co, char *options) { struct uart_port *port = console_port; -- 2.19.1