From: Peter Zijlstra <peterz@infradead.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC PATCH] i2c: remove use of in_atomic()
Date: Mon, 1 Apr 2019 13:21:09 +0200 [thread overview]
Message-ID: <20190401112109.GB12232@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190401111323.ajvo4drongc6dtel@ninjato>
On Mon, Apr 01, 2019 at 01:13:24PM +0200, Wolfram Sang wrote:
> > Why must we allow i2c usage with IRQs disabled? Just say NO?
>
> I'd love to. But quoting my patch description:
>
> "This matches the use cases for atomic I2C transfers I have seen so far:
> very late communication (mostly to a PMIC) to powerdown or reboot the
> system."
Ah, sorry, I missed that.
> And yes, I would never recommend a HW design to use I2C for shutting
> down/rebooting. But such HW is out there.
Can we then make the whole thing conditional on:
system_state > SYSTEM_RUNNING
Such that we're sure to never trigger this under any other conditions?
next prev parent reply other threads:[~2019-04-01 11:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 21:12 [RFC PATCH] i2c: remove use of in_atomic() Wolfram Sang
2019-03-28 8:10 ` Geert Uytterhoeven
2019-04-01 10:47 ` Peter Zijlstra
2019-04-01 11:13 ` Wolfram Sang
2019-04-01 11:21 ` Peter Zijlstra [this message]
2019-04-01 11:54 ` Wolfram Sang
2019-04-01 13:42 ` Peter Zijlstra
2019-04-01 15:13 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401112109.GB12232@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=fweisbec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox