From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4769C43381 for ; Mon, 1 Apr 2019 17:36:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B62421852 for ; Mon, 1 Apr 2019 17:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554140193; bh=+wlI0cjVRmdgViN4LMhf10l9tXbJ2VWvTTUUzVZNKmM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Cv+FSRWULNX+o3rJxfL8Ei4TL7oofKxaehSyQUW8yFjRxAVkg+f06fFBZDg9iVrFI GoR5iMc5uMJ5QoC5O4q/2s/sND+KxlQaVzeWEW8594k6CM63OLmWjwTlbEei1g7q/S eq1g7J8/x5Tm+AfXTJE7gVhTkg+gmFkFMjhCp3PU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388053AbfDARgc (ORCPT ); Mon, 1 Apr 2019 13:36:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:48180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733008AbfDARg0 (ORCPT ); Mon, 1 Apr 2019 13:36:26 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0000D20896; Mon, 1 Apr 2019 17:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554140186; bh=+wlI0cjVRmdgViN4LMhf10l9tXbJ2VWvTTUUzVZNKmM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oyyKWTSb/9w1NJIUYRIVLsASIM+n21hdiS74R1S3IZXr7Kn0AQNpjhpHHAoblcPDK Lya04MBQq7WNCQsTGgRPUTx6JRLhJzjQBmf19SL/dg/YKS/cTKclENrtgvAtigc1+G 7CAswOqpewuHGVeimhKHcXRP2L6nyE506xA1IFUc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Axel Lin , Thierry Reding , Bartosz Golaszewski Subject: [PATCH 4.4 123/131] gpio: adnp: Fix testing wrong value in adnp_gpio_direction_input Date: Mon, 1 Apr 2019 19:03:13 +0200 Message-Id: <20190401170101.777486796@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190401170051.645954551@linuxfoundation.org> References: <20190401170051.645954551@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Axel Lin commit c5bc6e526d3f217ed2cc3681d256dc4a2af4cc2b upstream. Current code test wrong value so it does not verify if the written data is correctly read back. Fix it. Also make it return -EPERM if read value does not match written bit, just like it done for adnp_gpio_direction_output(). Fixes: 5e969a401a01 ("gpio: Add Avionic Design N-bit GPIO expander support") Cc: Signed-off-by: Axel Lin Reviewed-by: Thierry Reding Signed-off-by: Bartosz Golaszewski Signed-off-by: Greg Kroah-Hartman --- drivers/gpio/gpio-adnp.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/drivers/gpio/gpio-adnp.c +++ b/drivers/gpio/gpio-adnp.c @@ -137,8 +137,10 @@ static int adnp_gpio_direction_input(str if (err < 0) goto out; - if (err & BIT(pos)) - err = -EACCES; + if (value & BIT(pos)) { + err = -EPERM; + goto out; + } err = 0;