From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7363C43381 for ; Mon, 1 Apr 2019 17:59:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A29CF2084B for ; Mon, 1 Apr 2019 17:59:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="BeuxmBL7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731626AbfDAR7l (ORCPT ); Mon, 1 Apr 2019 13:59:41 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:45626 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731266AbfDARRz (ORCPT ); Mon, 1 Apr 2019 13:17:55 -0400 Received: by mail-pl1-f193.google.com with SMTP id bf11so4793766plb.12 for ; Mon, 01 Apr 2019 10:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qCuthoMNLE7oG5BcFr/VLQrstKVLsbG6o5veAgiYBjM=; b=BeuxmBL7asgMN0dyz2ZltyV09uNTnzdrlVM412Q/FIANNWRzhPAoWj2LVD+pyPkZEs 5JAnL8SkKQv5hH7QHqzqg/zQFjeWiR/Tk2GaloGFlFeLQIBhRtzk+btrXgs3fAiikeDI jLccwbmAkLIwQsyARd+mbOdBSW6omtP8CuJ2E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qCuthoMNLE7oG5BcFr/VLQrstKVLsbG6o5veAgiYBjM=; b=tl6b7XBGWd3HQPIInU2dizm/UiZEqrW/LQ0NEt21fpVgTjRU0UyB1wzAkiF8FyhPyK WeGk2/AU0CuTo40GBNqgM8apw6Tgdy5MuJ94sICVpFw5AWgoTeuhRue5xD2BnHrR9wI7 KN1ut6I3C6QKrt4DxK3fX9eSNNlAckwts0kxClAP8wSLmS6RAt9pGPKGGvut8ebrx1NP JVpSSNf3GL/nL3KbRKCs05bKTgCv3WbdMUmx0+b5WzAcUD0qQZqB3nQ8BPwP9HqN/G/S +aepn6zJ8FlsK0sv2zvGb83xkCQz0Wz9PdLYIXZmCyJlDSjSQEKMeNZIpVOevOnwb1zU Oa+Q== X-Gm-Message-State: APjAAAXcea4uPnfOsMTWGUTrA/rT1g0g9+LblVNIuSvsZhc8gl40evC5 oeM3qiNpn2R2lNMzjkkXrFs1hQ== X-Google-Smtp-Source: APXvYqwarIcoctYERt192q6UgAo80DnvoKyoR+ep7xtU5CxnXWO+8jwnxPLBPxi0DiXXn5ekghGk2Q== X-Received: by 2002:a17:902:b43:: with SMTP id 61mr64908196plq.83.1554139074921; Mon, 01 Apr 2019 10:17:54 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id y12sm31370112pgq.64.2019.04.01.10.17.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Apr 2019 10:17:53 -0700 (PDT) From: Douglas Anderson To: Thierry Reding , Heiko Stuebner , Sean Paul Cc: linux-rockchip@lists.infradead.org, Laurent Pinchart , dri-devel@lists.freedesktop.org, Boris Brezillon , Ezequiel Garcia , =?UTF-8?q?Enric=20Balletb=C3=B2?= , Rob Herring , mka@chromium.org, Doug Anderson , Eric Anholt , Jeffy Chen , =?UTF-8?q?St=C3=A9phane=20Marchesin?= , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, Daniel Vetter Subject: [PATCH v5 2/7] drm/panel: simple: Add ability to override typical timing Date: Mon, 1 Apr 2019 10:17:19 -0700 Message-Id: <20190401171724.215780-3-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog In-Reply-To: <20190401171724.215780-1-dianders@chromium.org> References: <20190401171724.215780-1-dianders@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sean Paul This patch adds the ability to override the typical display timing for a given panel. This is useful for devices which have timing constraints that do not apply across the entire display driver (eg: to avoid crosstalk between panel and digitizer on certain laptops). The rules are as follows: - panel must not specify fixed mode (since the override mode will either be the same as the fixed mode, or we'll be unable to check the bounds of the overried) - panel must specify at least one display_timing range which will be used to ensure the override mode fits within its bounds Changes in v2: - Parse the full display-timings node (using the native-mode) (Rob) Changes in v3: - No longer parse display-timings subnode, use panel-timing (Rob) Changes in v4: - Don't add mode from timing if override was specified (Thierry) - Add warning if timing and fixed mode was specified (Thierry) - Don't add fixed mode if timing was specified (Thierry) - Refactor/rename a bit to avoid extra indentation from "if" tests - i should be unsigned (Thierry) - Add annoying WARN_ONs for some cases (Thierry) - Simplify 'No display_timing found' handling (Thierry) - Rename to panel_simple_parse_override_mode() (Thierry) Changes in v5: - Added Heiko's Tested-by Cc: Doug Anderson Cc: Eric Anholt Cc: Heiko Stuebner Cc: Jeffy Chen Cc: Rob Herring Cc: Stéphane Marchesin Cc: Thierry Reding Cc: devicetree@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Sean Paul Tested-by: Enric Balletbo i Serra Signed-off-by: Douglas Anderson Tested-by: Heiko Stuebner --- drivers/gpu/drm/panel/panel-simple.c | 109 +++++++++++++++++++++++++-- 1 file changed, 104 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 9e8218f6a3f2..ad4f4aac2d44 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -34,6 +34,7 @@ #include #include