From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E003FC43381 for ; Mon, 1 Apr 2019 15:26:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4CA02133F for ; Mon, 1 Apr 2019 15:26:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728655AbfDAP04 convert rfc822-to-8bit (ORCPT ); Mon, 1 Apr 2019 11:26:56 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:43291 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726514AbfDAP0z (ORCPT ); Mon, 1 Apr 2019 11:26:55 -0400 X-Originating-IP: 90.88.32.136 Received: from xps13 (aaubervilliers-681-1-91-136.w90-88.abo.wanadoo.fr [90.88.32.136]) (Authenticated sender: miquel.raynal@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 9509C40006; Mon, 1 Apr 2019 15:26:52 +0000 (UTC) Date: Mon, 1 Apr 2019 17:26:51 +0200 From: Miquel Raynal To: Aditya Pakki Cc: kjlu@umn.edu, Stefan Agner , Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: rawnand: vf610: Fix to check for NULL pointer dereference Message-ID: <20190401172651.158c05fe@xps13> In-Reply-To: <20190318232434.9246-1-pakki001@umn.edu> References: <20190318232434.9246-1-pakki001@umn.edu> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Aditya, Aditya Pakki wrote on Mon, 18 Mar 2019 18:24:34 -0500: > of_match_device can return NULL if there is no matching device is found. > The patch avoids a potential NULL pointer dereference by checking for the > return value and passing the error upstream. > > Signed-off-by: Aditya Pakki > --- > drivers/mtd/nand/raw/vf610_nfc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/nand/raw/vf610_nfc.c b/drivers/mtd/nand/raw/vf610_nfc.c > index a662ca1970e5..946abbb275c3 100644 > --- a/drivers/mtd/nand/raw/vf610_nfc.c > +++ b/drivers/mtd/nand/raw/vf610_nfc.c > @@ -850,6 +850,8 @@ static int vf610_nfc_probe(struct platform_device *pdev) > } > > of_id = of_match_device(vf610_nfc_dt_ids, &pdev->dev); > + if (!of_id) > + return -ENODEV; > nfc->variant = (enum vf610_nfc_variant)of_id->data; > > for_each_available_child_of_node(nfc->dev->of_node, child) { Applied to git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git on nand/next with the title changed to mtd: rawnand: vf610: Avoid a potential NULL pointer dereference and a space after the return statement. Thanks, Miquèl