Re: [PATCH v5 1/8] i2c: iproc: Extend I2C read up to 255 bytes

Wolfram Sang
2019-03-27T22:17:36Z

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

> + if (!((readl(iproc_i2c->base +
> + M_FIFO_CTRL_OFFSET) >>
> + M_FIFO_RX_CNT_SHIFT) &
> + M_FIFO_RX_CNT_MASK))

Don't be too strict with the 80 char limit. I think the above is hardly
readable...

> + break;
> +
> + msg->buf[iproc_i2c->rx_bytes] =
> + (readl(iproc_i2c->base + M_RX_OFFSET) >>
> + M_RX_DATA_SHIFT) & M_RX_DATA_MASK;

... this here is MUCH better.

Rest looks good.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]