Re: [PATCH v5 7/8] i2c: iproc: add NIC I2C support

Ray Jui
2019-04-02T17:57:42Z

On 4/2/2019 3:27 AM, Wolfram Sang wrote:
>
>> +#define IDM_CTRL_DIRECT_OFFSET 0x00
>
> And this IDM thing is also never used outside of the I2C context? In
> other words, it also doesn't need a seperate DT node?
>
>

That is correct. Only in the I2C context in our use case.

>> + /* indicates no slave mode support */
>> + bool no_slave;
>
> I would suggest to not use a flag, but to nullify the {un}reg_slave
> callbacks in probe depending on the type. That will also tell the
> i2c-core that slave functionality is not supported. And you can use if
> (!algo->reg_slave) as a flag, too.
>

Yes. Great idea. I'll make the change and remove reg_slave.

>> + iproc_i2c->type =
>> + (enum bcm_iproc_i2c_type) of_device_get_match_data(&pdev->dev);
>
> No need to cast a void*.
>

Yes will fix.

Thanks,

Ray