Re: [PATCH 2/2] tty: fix up a few remaining files without SPDX identifiers

Mukesh Ojha
2019-04-04T08:46:18Z

On 4/2/2019 7:37 PM, Greg Kroah-Hartman wrote:
> There were a few straggling files under drivers/tty/ that did not have
> any SPDX identifier either because they entered the tree recently, or
> they somehow missed the mass-tagging of commit b24413180f56 ("License
> cleanup: add SPDX GPL-2.0 license identifier to files with no license")
>
> This commit follows the same rule as b24413180f56 ("License cleanup: add
> SPDX GPL-2.0 license identifier to files with no license") where files
> without any specified license in them fall under GPL-2.0 as the correct
> license for the individual file. Add that identifier to these remaining
> files so that we don't have to guess at the license of them in the
> future.
>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/tty/serial/8250/8250_men_mcb.c | 1 +
> drivers/tty/serial/sn_console.c | 1 +
> drivers/tty/vcc.c | 1 +
> drivers/tty/vt/.gitignore | 1 +
> drivers/tty/vt/cp437.uni | 1 +
> drivers/tty/vt/defkeymap.c_shipped | 1 +
> drivers/tty/vt/defkeymap.map | 1 +
> 7 files changed, 7 insertions(+)
>
> diff --git a/drivers/tty/serial/8250/8250_men_mcb.c b/drivers/tty/serial/8250/8250_men_mcb.c
> index 127017cc41d9..02c5aff58a74 100644
> --- a/drivers/tty/serial/8250/8250_men_mcb.c
> +++ b/drivers/tty/serial/8250/8250_men_mcb.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
> #include <linux/device.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> diff --git a/drivers/tty/serial/sn_console.c b/drivers/tty/serial/sn_console.c
> index fe9170731c16..283493358a62 100644
> --- a/drivers/tty/serial/sn_console.c
> +++ b/drivers/tty/serial/sn_console.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * C-Brick Serial Port (and console) driver for SGI Altix machines.
> *
> diff --git a/drivers/tty/vcc.c b/drivers/tty/vcc.c
> index 58b454c34560..d2a1e1228c82 100644
> --- a/drivers/tty/vcc.c
> +++ b/drivers/tty/vcc.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
> /* vcc.c: sun4v virtual channel concentrator
> *
> * Copyright (C) 2017 Oracle. All rights reserved.
> diff --git a/drivers/tty/vt/.gitignore b/drivers/tty/vt/.gitignore
> index 83683a2d8e6a..9b38b85f9d9a 100644
> --- a/drivers/tty/vt/.gitignore
> +++ b/drivers/tty/vt/.gitignore

.gitignore ?

Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Cheers,
-Mukesh

> @@ -1,2 +1,3 @@
> +# SPDX-License-Identifier: GPL-2.0
> consolemap_deftbl.c
> defkeymap.c
> diff --git a/drivers/tty/vt/cp437.uni b/drivers/tty/vt/cp437.uni
> index bc6163484f62..a1991904c559 100644
> --- a/drivers/tty/vt/cp437.uni
> +++ b/drivers/tty/vt/cp437.uni
> @@ -1,3 +1,4 @@
> +# SPDX-License-Identifier: GPL-2.0
> #
> # Unicode table for IBM Codepage 437. Note that there are many more
> # substitutions that could be conceived (for example, thick-line
> diff --git a/drivers/tty/vt/defkeymap.c_shipped b/drivers/tty/vt/defkeymap.c_shipped
> index d2208dfe3f67..c7095fb7d2d1 100644
> --- a/drivers/tty/vt/defkeymap.c_shipped
> +++ b/drivers/tty/vt/defkeymap.c_shipped
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
> /* Do not edit this file! It was automatically generated by */
> /* loadkeys --mktable defkeymap.map > defkeymap.c */
>
> diff --git a/drivers/tty/vt/defkeymap.map b/drivers/tty/vt/defkeymap.map
> index 50b30cace261..37f1ac6ddfb9 100644
> --- a/drivers/tty/vt/defkeymap.map
> +++ b/drivers/tty/vt/defkeymap.map
> @@ -1,3 +1,4 @@
> +# SPDX-License-Identifier: GPL-2.0
> # Default kernel keymap. This uses 7 modifier combinations.
> keymaps 0-2,4-5,8,12
> # Change the above line into