Re: [PATCH 03/10] PCI: dwc: Move config space capability search API

Thierry Reding
2019-03-28T12:33:32Z

[-- Attachment #1: Type: text/plain, Size: 942 bytes --]

On Tue, Mar 26, 2019 at 08:43:20PM +0530, Vidya Sagar wrote:
> move PCIe config space capability search API to common designware file
> as this can be used by both host and ep mode codes.
> It also adds extended capability search APIs.
>
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
> drivers/pci/controller/dwc/pcie-designware-ep.c | 37 +------------
> drivers/pci/controller/dwc/pcie-designware.c | 73 +++++++++++++++++++++++++
> drivers/pci/controller/dwc/pcie-designware.h | 3 +
> 3 files changed, 78 insertions(+), 35 deletions(-)

Just out of curiosity: is there any reason why this driver needs to
reimplement this? Couldn't this be made to work using the standard
pci_find_next_capability() function?

Other than that it might be a good idea to split this into two patches,
one that moves the existing functionality to the common code and another
that adds the extra functionality.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]