From: Tony Lindgren <tony@atomide.com>
To: Roger Quadros <rogerq@ti.com>
Cc: nsekhar@ti.com, s-anna@ti.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/4] bus: ti-sysc: Add generic enable/disable functions
Date: Tue, 2 Apr 2019 10:14:49 -0700 [thread overview]
Message-ID: <20190402171449.GN49658@atomide.com> (raw)
In-Reply-To: <20190402133752.6912-3-rogerq@ti.com>
* Roger Quadros <rogerq@ti.com> [190402 13:38]:
> For non legacy cases, add generic sysc_enable_module()
> and sysc_disable_module() functions.
Looks OK to me. Can you please add a comment mentioning that we're
not currently blocking clockdomain autoidle? See clkdm_deny_idle()
use in omap_hwmod.c.
> + if (idlemodes & BIT(SYSC_IDLE_SMART_WKUP)) {
> + best_mode = SYSC_IDLE_SMART_WKUP;
> + } else if (idlemodes & BIT(SYSC_IDLE_SMART)) {
> + best_mode = SYSC_IDLE_SMART;
> + } else if (idlemodes & SYSC_IDLE_FORCE) {
> + best_mode = SYSC_IDLE_FORCE;
> + } else {
> + dev_err(dev, "%s: invalid midlemode\n", __func__);
> + return -EINVAL;
> + }
...
> + if (idlemodes & BIT(SYSC_IDLE_SMART_WKUP)) {
> + best_mode = SYSC_IDLE_SMART_WKUP;
> + } else if (idlemodes & BIT(SYSC_IDLE_SMART)) {
> + best_mode = SYSC_IDLE_SMART;
> + } else if (idlemodes & SYSC_IDLE_FORCE) {
> + best_mode = SYSC_IDLE_FORCE;
> + } else {
> + dev_err(dev, "%s: invalid sidlemode\n", __func__);
> + return -EINVAL;
> + }
Can you please add a helper function for getting the best
idle mode?
Regards,
Tony
next prev parent reply other threads:[~2019-04-02 17:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 13:37 [RFC PATCH 0/4] bus: ti-sysc: Add generic enable/disable & PRUSS Roger Quadros
2019-04-02 13:37 ` [RFC PATCH 1/4] ARM: dts: dra7: Keep usb_otg_ss3 and usb_otg_ss4 disabled Roger Quadros
2019-04-02 16:22 ` Tony Lindgren
2019-04-03 8:38 ` Roger Quadros
2019-04-03 14:53 ` Roger Quadros
2019-04-03 15:09 ` Tony Lindgren
2019-04-02 13:37 ` [RFC PATCH 2/4] bus: ti-sysc: Add generic enable/disable functions Roger Quadros
2019-04-02 17:14 ` Tony Lindgren [this message]
2019-04-02 13:37 ` [RFC PATCH 3/4] bus: ti-sysc: Add support for PRU-ICSS type Roger Quadros
2019-04-02 13:37 ` [RFC PATCH 4/4] bus: ti-sysc: Ensure PRU-ICSS doesn't break suspend/resume Roger Quadros
2019-04-02 16:57 ` Tony Lindgren
2019-04-03 8:46 ` Roger Quadros
2019-04-02 13:39 ` [RFC PATCH 0/4] bus: ti-sysc: Add generic enable/disable & PRUSS Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402171449.GN49658@atomide.com \
--to=tony@atomide.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=rogerq@ti.com \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).