Re: [RFC][PATCH 0/3] tracing: Make error_log per instance

Steven Rostedt
2019-04-02T20:57:25Z

On Tue, 02 Apr 2019 15:42:16 -0500
Tom Zanussi <zanussi@kernel.org> wrote:

> Hi Steve,
>
> On Tue, 2019-04-02 at 14:29 -0400, Steven Rostedt wrote:
> > Hi Tom,
> >
> > I noticed that you created an error_log file in every instance, but
> > they all show the same errors. These three patches make it so that
> > the errors appear in the instance directory that they happened in.
> > If you write a bad error to
> >
> > /sys/kernel/tracing/instance/foo/events/sched/sched_switch/hist
> >
> > It appears only in
> >
> > /sys/kernel/tracing/instances/foo/error_log
> >
> > Which I think is the proper approach, especially instances should not
> > affect the top directory or other instances.
> >
> > For those errors that do not have an associated instance (creating a
> > kprobe/uprobe event or perf), a NULL passed to tracing_log_err() will
> > result in the error message in the top level error message.
> >
> > Do you (or Masami) have any issues with this patch set?
> >
> > If not, please add a "reviewed-by" or "acked-by" and I'll add it
> > to your patch series and push them to for-next (after more testing).
> >
>
> Looks good, thanks for doing this. You can add my:
>
> Reviewed-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> Tested-by: Tom Zanussi <tom.zanussi@linux.intel.com>

Thanks, will do.

>
> FYI, I noticed one bit of trailing whitespace in 2/3 - you might want
> to run it through checkpatch again before you merge ;-)

Hmm, strange that git didn't complain about that. It usually does on a
commit. Or perhaps (more likely) it did, and I didn't notice ;-)

-- Steve