From: Yury Norov <yury.norov@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Arnd Bergmann <arnd@arndb.de>, Kees Cook <keescook@chromium.org>,
Matthew Wilcox <willy@infradead.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Mike Travis <travis@sgi.com>
Cc: Yury Norov <ynorov@marvell.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/5] lib: rework bitmap_parselist and tests
Date: Wed, 3 Apr 2019 07:54:27 +0300 [thread overview]
Message-ID: <20190403045427.GA16444@yury-thinkpad> (raw)
In-Reply-To: <20190403044540.16322-1-ynorov@marvell.com>
On Wed, Apr 03, 2019 at 07:45:35AM +0300, Yury Norov wrote:
> bitmap_parselist has been evolved from a pretty simple idea for long and
> now lacks for refactoring. It is not structured, has nested loops and a
> set of opaque-named variables.
>
> Things are more complicated because bitmap_parselist() is a part of user
> interface, and its behavior should not change.
>
> In this patchset
> - bitmap_parselist_user() made a wrapper on bitmap_parselist();
> - bitmap_parselist() reworked (patch 2);
> - time measurement in test_bitmap_parselist switched to ktime_get
> (patch 3);
> - new tests introduced (patch 4), and
> - bitmap_parselist_user() testing enabled with the same testset as
> bitmap_parselist() (patch 5).
>
> v1: https://lkml.org/lkml/2018/12/23/50
> v2: https://www.spinics.net/lists/kernel/msg3048976.html
> v3: Implementation of an approach with copying the data to
> kernel space in bitmap_parselist_user() instead of parsing
> user data byte by byte. For me, it looks better than v2.
Hi all,
I'm sorry for noise. My mail server works unstable, and it would be
better to submit patches 4 and 5 a bit later. They are actually the
same as in v2.
Yury
next prev parent reply other threads:[~2019-04-03 4:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 4:45 [PATCH v3 0/5] lib: rework bitmap_parselist and tests Yury Norov
2019-04-03 4:45 ` [PATCH 1/5] lib: make bitmap_parselist_user() a wrapper on bitmap_parselist() Yury Norov
2019-04-03 11:15 ` Andy Shevchenko
2019-04-03 11:17 ` Andy Shevchenko
2019-04-03 12:17 ` Rasmus Villemoes
2019-04-03 12:36 ` Andy Shevchenko
2019-04-03 4:45 ` [PATCH 2/5] lib: rework bitmap_parselist Yury Norov
2019-04-03 11:22 ` Andy Shevchenko
2019-04-03 4:45 ` [PATCH 3/5] lib/test_bitmap: switch test_bitmap_parselist to ktime_get() Yury Norov
2019-04-03 4:54 ` Yury Norov [this message]
2019-04-03 11:23 ` [PATCH v3 0/5] lib: rework bitmap_parselist and tests Andy Shevchenko
2019-04-03 11:24 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2019-04-03 4:40 Yury Norov
2019-04-03 4:39 Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403045427.GA16444@yury-thinkpad \
--to=yury.norov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=travis@sgi.com \
--cc=willy@infradead.org \
--cc=ynorov@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox