Re: [PATCH] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel

Chao Fan
2019-03-29T09:19:45Z

On Fri, Mar 29, 2019 at 08:39:45AM +0000, Junichi Nomura wrote:
>On 3/29/19 5:29 PM, Chao Fan wrote:
>> On Fri, Mar 29, 2019 at 07:20:38AM +0000, Junichi Nomura wrote:
>>> + return __efi_get_rsdp_addr(config_tables, nr_tables, efi_64);
>>> +#else
>>> + return 0;
>>> #endif
>>> - return rsdp_addr;
>>
>> I remeber the rsdp_addr is defined before #ifdef CONFIG_EFI
>> If so, you don't need
>> #else
>> return 0;
>
>I moved the whole __efi_get_rsdp_addr() to the inside of #ifdef CONFIG_EFI
>and both kexec_get_rsdp_addr() and efi_get_rsdp_addr() just return 0 if
>CONFIG_EFI is not defined.

Ah, got it. I will add the patch and do a simple test.
>
>> BY the way, what's your patch based on? I like add patch on my local
>> branch and then review code, but failed.
>> I try to use 'patch -p1 <' your patch to the latest tip master branch,
>> but failed.
>
>The patch is based on Linus's v5.1-rc2.

Thanks,
Chao Fan

>
>--
>Jun'ichi Nomura, NEC Corporation / NEC Solution Innovators, Ltd.
>
>