From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5C03C4360F for ; Wed, 3 Apr 2019 08:23:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB4512084C for ; Wed, 3 Apr 2019 08:23:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728892AbfDCIXV (ORCPT ); Wed, 3 Apr 2019 04:23:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38588 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbfDCIXV (ORCPT ); Wed, 3 Apr 2019 04:23:21 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B5BE2859FB; Wed, 3 Apr 2019 08:23:20 +0000 (UTC) Received: from dhcp-128-65.nay.redhat.com (ovpn-12-59.pek2.redhat.com [10.72.12.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 440BF5C234; Wed, 3 Apr 2019 08:23:16 +0000 (UTC) Date: Wed, 3 Apr 2019 16:23:13 +0800 From: Dave Young To: "bhe@redhat.com" Cc: Chao Fan , Junichi Nomura , Borislav Petkov , "kasong@redhat.com" , "x86@kernel.org" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel Message-ID: <20190403082313.GA14838@dhcp-128-65.nay.redhat.com> References: <20190328064343.GA1877@MiWiFi-R3L-srv> <20190328074337.GA9470@jeru.linux.bs1.fc.nec.co.jp> <20190328155256.GP22720@zn.tnic> <20190401000837.GA5170@jeru.linux.bs1.fc.nec.co.jp> <20190402120319.GA7605@dhcp-128-65.nay.redhat.com> <20190403053459.GD1555@localhost.localdomain> <20190403055340.GA11976@dhcp-128-65.nay.redhat.com> <20190403063911.GA2579@dhcp-128-65.nay.redhat.com> <20190403073023.GF1555@localhost.localdomain> <20190403075015.GQ7627@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190403075015.GQ7627@MiWiFi-R3L-srv> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 03 Apr 2019 08:23:20 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/19 at 03:50pm, Baoquan He wrote: > On 04/03/19 at 03:30pm, Chao Fan wrote: > > On Wed, Apr 03, 2019 at 02:39:11PM +0800, Dave Young wrote: > > >> Actually I got some different kexec test results. > > >> > > >> Yesterday, with my installed kernel (based on git head several weeks > > >> ago), kexec kernel panics. > > >> > > >> Then I tried latest mainline with git pull, everything works, (with or > > >> without the patch, and can not reproduce the bug this patch is fixing) > > >> > > >> Today, test again, kexec reboot hangs (with or without your patch), but > > >> kdump works always (with or without the patch) > > >> > > >> It is weird to me. Probably I need find out why I can not reproduce the > > >> bug this patch is addressing first. > > >> > > >> earlyprintk seems not working for me anymore, it is not easy to debug on > > >> laptop now. > > >> > > >> But the patch itself is clear, I think it should be good. There might be > > >> other things broken. > > > > > >Disable your immovable mem code then everything works for me. There > > >might be something wrong in the code. Also "nokaslr" does not help, it > > >should be another problem > > > > If "nokaslr" doesn't help, so I think > > >+ /*num_immovable_mem = count_immovable_mem_regions();*/ > > also doesn't help. I think the problem is from get_rsdp_addr(). > > Yes, seems get_rsdp_addr() has issue in this case. I am wondering if we > can adjust the postion of get_rsdp_addr() calling. If nokaslr is > specified, no need to get rsdp? I assumed the early code is only be useful for kaslr, if this is true then no need to get rsdp in case nokaslr. But I vaguely remember Boris want the boot_params rsdp pointer be a general thing, I did not followed up these patch discussions, need to see how Boris thinks about this. Thanks Dave