Re: [PATCH 1/1] mfd: yeeloong_kb3310b: support KB3310B EC for Lemote Yeeloong laptops.

Matt Turner
2020-01-23T00:23:06Z

On Sat, Mar 30, 2019 at 1:19 AM Tom Li <biergaizi2009@gmail.com> wrote:
>
> From: Yifeng Li <tomli@tomli.me>
>
> Lemote Yeeloong is a laptop powered by Loongson 2F MIPS processor,
> primarily a demo platform for hobbyists and developers. It uses an
> ENE KB3310B Embedded Controller with customized firmware to implement
> hardware and power management.
>
> A monolithic platform driver code for those functionality has existed
> out-of-tree for many years. This commit creates a MFD driver for the EC
> chip on Yeeloong laptop to isolate EC-related code from core MIPS code,
> and serves as the foundation of various subdrivers.
>
> NOTE: A regmap could be the reasonable abstraction for I/O, but (1)
> it requires some additional refactoring to convert the shutdown/wakeup
> routines in board files to subdrivers, and (2) we're only using simple
> reads/writes, repmap only adds boilerplates to the existing files without
> additional benefits. We simply export the EC-related functions for now,
> until we come back to refactor the board files.
>
> Signed-off-by: Yifeng Li <tomli@tomli.me>

Did you give up on upstreaming this code? That would be a shame, and
somewhat ironic given that you were frustrated about lack of review,
etc, and then never responded to the review given :(