public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] staging:iio:accel:adis16203: add SPDX license identifier tag
@ 2019-04-03  9:41 Nicholas Mc Guire
  2019-04-03  9:41 ` [PATCH 2/2] staging:iio:accel:adis16240: " Nicholas Mc Guire
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Nicholas Mc Guire @ 2019-04-03  9:41 UTC (permalink / raw)
  To: Lars-Peter Clausen
  Cc: Michael Hennerich, Jonathan Cameron, Hartmut Knaack,
	Peter Meerwald-Stadler, Greg Kroah-Hartman, linux-iio, devel,
	linux-kernel, Nicholas Mc Guire

Pop in the SPDX tag as the license is clearly indicated
as GPL V2 or later this should also be indicated with a SPDX license
identifier tag.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---

chackpatch.pl was warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

Patch was compile tested with: X86_64_defconfig + SPI=y, IIO=m
STAGING=y, ADIS16203=m

Patch is against 5.1-rc3 (localversion-next is next-20190403)

 drivers/staging/iio/accel/adis16203.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
index 5cc96c80..cf9d41a 100644
--- a/drivers/staging/iio/accel/adis16203.c
+++ b/drivers/staging/iio/accel/adis16203.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  * ADIS16203 Programmable 360 Degrees Inclinometer
  *
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] staging:iio:accel:adis16240: add SPDX license identifier tag
  2019-04-03  9:41 [PATCH 1/2] staging:iio:accel:adis16203: add SPDX license identifier tag Nicholas Mc Guire
@ 2019-04-03  9:41 ` Nicholas Mc Guire
  2019-04-03 12:37 ` [PATCH 1/2] staging:iio:accel:adis16203: " Himanshu Jha
  2019-04-03 13:00 ` Greg Kroah-Hartman
  2 siblings, 0 replies; 4+ messages in thread
From: Nicholas Mc Guire @ 2019-04-03  9:41 UTC (permalink / raw)
  To: Lars-Peter Clausen
  Cc: Michael Hennerich, Jonathan Cameron, Hartmut Knaack,
	Peter Meerwald-Stadler, Greg Kroah-Hartman, linux-iio, devel,
	linux-kernel, Nicholas Mc Guire

Pop in the SPDX tag as the license is clearly indicated
as GPL V2 or later this should also be indicated with a SPDX license
identifier tag.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---

chackpatch.pl was warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

Patch was compile tested with: x86_64_defconfig + SPI=y, IIO=m
STAGING=y, ADIS16240=m

Patch is against 5.1-rc3 (localversion-next is next-20190403)

 drivers/staging/iio/accel/adis16240.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
index 24e525f..b2d71ae 100644
--- a/drivers/staging/iio/accel/adis16240.c
+++ b/drivers/staging/iio/accel/adis16240.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  * ADIS16240 Programmable Impact Sensor and Recorder driver
  *
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] staging:iio:accel:adis16203: add SPDX license identifier tag
  2019-04-03  9:41 [PATCH 1/2] staging:iio:accel:adis16203: add SPDX license identifier tag Nicholas Mc Guire
  2019-04-03  9:41 ` [PATCH 2/2] staging:iio:accel:adis16240: " Nicholas Mc Guire
@ 2019-04-03 12:37 ` Himanshu Jha
  2019-04-03 13:00 ` Greg Kroah-Hartman
  2 siblings, 0 replies; 4+ messages in thread
From: Himanshu Jha @ 2019-04-03 12:37 UTC (permalink / raw)
  To: Nicholas Mc Guire
  Cc: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
	Hartmut Knaack, Peter Meerwald-Stadler, Greg Kroah-Hartman,
	linux-iio, devel, linux-kernel

On Wed, Apr 03, 2019 at 11:41:28AM +0200, Nicholas Mc Guire wrote:
> Pop in the SPDX tag as the license is clearly indicated
> as GPL V2 or later this should also be indicated with a SPDX license
> identifier tag.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
> 
> chackpatch.pl was warning:
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> 
> Patch was compile tested with: X86_64_defconfig + SPI=y, IIO=m
> STAGING=y, ADIS16203=m
> 
> Patch is against 5.1-rc3 (localversion-next is next-20190403)
> 
>  drivers/staging/iio/accel/adis16203.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
> index 5cc96c80..cf9d41a 100644
> --- a/drivers/staging/iio/accel/adis16203.c
> +++ b/drivers/staging/iio/accel/adis16203.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later

SPDX-License-Identifier: GPL-2.0+ ?

Documentation/process/license-rules.rst

 For 'GNU General Public License (GPL) version 2 or any later version' use:
   SPDX-License-Identifier: GPL-2.0+

The following should also be removed in this same patch:

	* Licensed under the GPL-2 or later.

And lastly, MODULE_LICENSE() should also be checked, which appear
to be correct in its current form.

>  /*
>   * ADIS16203 Programmable 360 Degrees Inclinometer
>   *
> -- 
> 2.1.4
> 

-- 
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] staging:iio:accel:adis16203: add SPDX license identifier tag
  2019-04-03  9:41 [PATCH 1/2] staging:iio:accel:adis16203: add SPDX license identifier tag Nicholas Mc Guire
  2019-04-03  9:41 ` [PATCH 2/2] staging:iio:accel:adis16240: " Nicholas Mc Guire
  2019-04-03 12:37 ` [PATCH 1/2] staging:iio:accel:adis16203: " Himanshu Jha
@ 2019-04-03 13:00 ` Greg Kroah-Hartman
  2 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2019-04-03 13:00 UTC (permalink / raw)
  To: Nicholas Mc Guire
  Cc: Lars-Peter Clausen, devel, Michael Hennerich, linux-iio,
	linux-kernel, Peter Meerwald-Stadler, Hartmut Knaack,
	Jonathan Cameron

On Wed, Apr 03, 2019 at 11:41:28AM +0200, Nicholas Mc Guire wrote:
> Pop in the SPDX tag as the license is clearly indicated
> as GPL V2 or later this should also be indicated with a SPDX license
> identifier tag.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>

I sent patches yesterday to fix up all of drivers/staging/ for all spdx
issues so as to keep people from accidentally getting this wrong.  That
patch is now in my tree and will show up in linux-next tomorrow.

Sorry,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-04-03 13:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-03  9:41 [PATCH 1/2] staging:iio:accel:adis16203: add SPDX license identifier tag Nicholas Mc Guire
2019-04-03  9:41 ` [PATCH 2/2] staging:iio:accel:adis16240: " Nicholas Mc Guire
2019-04-03 12:37 ` [PATCH 1/2] staging:iio:accel:adis16203: " Himanshu Jha
2019-04-03 13:00 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox