From: Dan Carpenter <dan.carpenter@oracle.com>
To: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtlwifi: Remove unwanted parentheses
Date: Wed, 3 Apr 2019 19:21:45 +0300 [thread overview]
Message-ID: <20190403162145.GK32613@kadam> (raw)
In-Reply-To: <20190403161803.GE32590@kadam>
On Wed, Apr 03, 2019 at 07:18:03PM +0300, Dan Carpenter wrote:
> data_bit = (data & BIT(i)) ? 1 : 0;
I quite like the !! idiom also...
data_bit = !!(data & BIT(i));
regards,
dan carpenter
next prev parent reply other threads:[~2019-04-03 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 16:04 [PATCH] Staging: rtlwifi: Remove unwanted parentheses Madhumitha Prabakaran
2019-04-03 16:18 ` Dan Carpenter
2019-04-03 16:21 ` Dan Carpenter [this message]
2019-04-03 22:50 ` Madhumthia Prabakaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403162145.GK32613@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madhumithabiw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox