From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20484C4360F for ; Wed, 3 Apr 2019 16:22:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E1849206C0 for ; Wed, 3 Apr 2019 16:22:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="OeKYjaxM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726582AbfDCQWC (ORCPT ); Wed, 3 Apr 2019 12:22:02 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:40492 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726099AbfDCQWC (ORCPT ); Wed, 3 Apr 2019 12:22:02 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x33GJ1bW114342; Wed, 3 Apr 2019 16:21:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=rjwBe8nJXu9SNBhKYDwJ/ahxe69oGl7wuunLYAn9owc=; b=OeKYjaxMatQpDdYCThEnQ6SIqYCwa7EnNbk45xHkJX3+mLofSlpSAkwo+f/ih1y8hJkP D3/B452nVoSiRGAkmUQfO9vHGyACbvIF+zXGzcNu94mlsVFj+3Skmmr7M0GM75YQuvTS aR9XTZ15yL+40GTvr+5VgcY+QlYuFBB5LYwW1DUbU2QPqw9y0lKH2ODIgQTA2tLGEbqk gCEURfB0m0abCJEefehj96IPcA9HxdkkYmKUsAQ8Dk54jgvsZDnCCdUg0+8APDgqitNI p1ulhGTJJ5SYW7ujyIGQgaGhn5eIYBcsAo6YvYdhX5d5DIRkFZO2Ylmj9a+EcJ0lqNcC Uw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2130.oracle.com with ESMTP id 2rhwyda9mh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Apr 2019 16:21:57 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x33GK9BU054525; Wed, 3 Apr 2019 16:21:56 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2rm8f56jps-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Apr 2019 16:21:56 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x33GLtSe027321; Wed, 3 Apr 2019 16:21:55 GMT Received: from kadam (/41.202.241.37) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 03 Apr 2019 09:21:54 -0700 Date: Wed, 3 Apr 2019 19:21:45 +0300 From: Dan Carpenter To: Madhumitha Prabakaran Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: rtlwifi: Remove unwanted parentheses Message-ID: <20190403162145.GK32613@kadam> References: <20190403160445.11110-1-madhumithabiw@gmail.com> <20190403161803.GE32590@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190403161803.GE32590@kadam> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9216 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=780 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904030110 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9216 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=831 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904030111 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 03, 2019 at 07:18:03PM +0300, Dan Carpenter wrote: > data_bit = (data & BIT(i)) ? 1 : 0; I quite like the !! idiom also... data_bit = !!(data & BIT(i)); regards, dan carpenter