From: Darren Hart <dvhart@infradead.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: Andy Shevchenko <andy@infradead.org>,
platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: alienware-wmi: fix kfree on potentially uninitialized pointer
Date: Wed, 3 Apr 2019 15:26:26 -0700 [thread overview]
Message-ID: <20190403222626.GA11745@wrath> (raw)
In-Reply-To: <424c2bba-1e17-3131-c15b-44462c57e22d@canonical.com>
On Wed, Apr 03, 2019 at 11:05:12PM +0100, Colin Ian King wrote:
> On 03/04/2019 23:02, Darren Hart wrote:
> > On Sat, Mar 30, 2019 at 12:17:12AM +0000, Colin King wrote:
> >> From: Colin Ian King <colin.king@canonical.com>
> >>
> >> Currently the kfree of output.pointer can be potentially freeing
> >> an uninitalized pointer in the case where out_data is NULL. Fix this
> >> by reworking the case where out_data is not-null to perform the
> >> ACPI status check and also the kfree of outpoint.pointer in one block
> >> and hence ensuring the pointer is only freed when it has been used.
> >>
> >> Also replace the if (ptr != NULL) idiom with just if (ptr).
> >>
> >> Fixes: ff0e9f26288d ("platform/x86: alienware-wmi: Correct a memory leak")
> >> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> >
> > Thanks for the catch Colin, queued for testing.
> >
> > Did you trigger this error or detect it via review or static analysis?
> >
> Static analysis, I'm now running a licensed version of Coverity on one
> of our servers.
We typically include the tool used to identify such bugs, and I see several such
tags for Coverity in the logs. Was there a reason not to include that tag? If
just an oversight, can you provide that tag and I'll amend the commit.
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2019-04-03 22:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 0:17 [PATCH] platform/x86: alienware-wmi: fix kfree on potentially uninitialized pointer Colin King
2019-04-03 22:02 ` Darren Hart
2019-04-03 22:05 ` Colin Ian King
2019-04-03 22:26 ` Darren Hart [this message]
2019-04-03 22:27 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403222626.GA11745@wrath \
--to=dvhart@infradead.org \
--cc=andy@infradead.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox