From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1D2AC4360F for ; Wed, 3 Apr 2019 22:50:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82ACE2075D for ; Wed, 3 Apr 2019 22:50:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WSEhtESO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726372AbfDCWun (ORCPT ); Wed, 3 Apr 2019 18:50:43 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:33542 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726193AbfDCWun (ORCPT ); Wed, 3 Apr 2019 18:50:43 -0400 Received: by mail-ot1-f68.google.com with SMTP id j10so585018otq.0 for ; Wed, 03 Apr 2019 15:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BWUvQY5fYTpMiCwQxTv/UbFvftOVQBGnCVwUk7hVsHQ=; b=WSEhtESOMo2luXCGXvUENspgtK4JlY2khKTTwQWy6x8bdYnUSjDCWCYg4mq7fTRqIZ 7wRr2TEBUyAiTMD8ses6nvoLCU+mikOhuvuaI5cYtzBx9Wjvy32fZb8BZ8SRcgjcRJwN AMJ9EaXcVuyr1fN/slaEmKqzUmjxUeP0ZySnnIMKSicD89iJ7OK5DRWtU+Uw4v1N+New t6teMP+SHRFP1B1xGnTcD6/WS/INdVG4X2XtVY0j5JO24OxCbaXrPefaMoPFIN+lj2of 5DH8zEzPv8p6NKqeVWVvBkxgI17HdjQTEOEg6iFWxl8EzvWiCyQJp+uPB+S000+2a4HU PFLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BWUvQY5fYTpMiCwQxTv/UbFvftOVQBGnCVwUk7hVsHQ=; b=oGoR46KELzkYQ8pTyb9UG95uezQuy+TrZlssJdDteFamrhERdeHagxZJeo2tzNHjrV 1jOr+mJ35l9y3qQtWWhN+vtxowIken3c+0zU6Vgglnzje15CCGfk0H3iJmG4h1FoJq6B Ef7Qmx0MPLMipt+H0oFFMQItylFMh9Nuu3wfu5Y9ecv6WWs6EHul1BjqzoTiR8ZyZZzE NOoNCZlWzFMVO5NXg+YuKrWhOwDbXbd387iZhTCTigTMeFPH8gF1kNwb10IssiB9lMjT O4rwNxgxJcUFKp7HPHaS74xRArTtHif1KxNQ4yG2oBKAOgnma8iZAD79Fdr6h/G/j2dF H32g== X-Gm-Message-State: APjAAAVp8ZM0/ISHxw4fKDbEAqgtpelz11LGTCgtywQlcgNEXGebLdN5 ZZIr1IjQ7mCLygtpTmYjLLo= X-Google-Smtp-Source: APXvYqwG+8i/L4wDriwrUrYC1kUU8akc9iBmmBXCkgfFlyQE2akAKZFQpp0lEv6DY26watwawVvYWQ== X-Received: by 2002:a9d:871:: with SMTP id 104mr1488218oty.315.1554331842226; Wed, 03 Apr 2019 15:50:42 -0700 (PDT) Received: from madhuleo ([2605:6000:1023:606d:1876:bc0b:8981:17be]) by smtp.gmail.com with ESMTPSA id y1sm7883198ota.38.2019.04.03.15.50.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Apr 2019 15:50:41 -0700 (PDT) Date: Wed, 3 Apr 2019 17:50:39 -0500 From: Madhumthia Prabakaran To: Dan Carpenter , gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: rtlwifi: Remove unwanted parentheses Message-ID: <20190403225038.GA22678@madhuleo> References: <20190403160445.11110-1-madhumithabiw@gmail.com> <20190403161803.GE32590@kadam> <20190403162145.GK32613@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190403162145.GK32613@kadam> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 03, 2019 at 07:21:45PM +0300, Dan Carpenter wrote: > On Wed, Apr 03, 2019 at 07:18:03PM +0300, Dan Carpenter wrote: > > data_bit = (data & BIT(i)) ? 1 : 0; > > I quite like the !! idiom also... > > data_bit = !!(data & BIT(i)); Thanks for reviewing it. > > regards, > dan carpenter