From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE7BC4360F for ; Thu, 4 Apr 2019 17:04:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91E79206DF for ; Thu, 4 Apr 2019 17:04:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729295AbfDDRE2 (ORCPT ); Thu, 4 Apr 2019 13:04:28 -0400 Received: from foss.arm.com ([217.140.101.70]:36106 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726418AbfDDRE2 (ORCPT ); Thu, 4 Apr 2019 13:04:28 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BB852168F; Thu, 4 Apr 2019 10:04:27 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A575D3F557; Thu, 4 Apr 2019 10:04:25 -0700 (PDT) Date: Thu, 4 Apr 2019 18:04:23 +0100 From: Will Deacon To: Jeremy Linton Cc: linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, rjw@rjwysocki.net, lenb@kernel.org, mark.rutland@arm.com, sudeep.holla@arm.com, james.morse@arm.com, lorenzo.pieralisi@arm.com, linuxarm@huawei.com Subject: Re: [PATCH 4/4] perf: arm_spe: Enable ACPI/Platform automatic module loading Message-ID: <20190404170423.GC28932@fuggles.cambridge.arm.com> References: <20190326223938.5365-1-jeremy.linton@arm.com> <20190326223938.5365-5-jeremy.linton@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190326223938.5365-5-jeremy.linton@arm.com> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 26, 2019 at 05:39:38PM -0500, Jeremy Linton wrote: > Lets add the MODULE_TABLE and platform id_table entries so that > the SPE driver can attach to the ACPI platform device created by > the core pmu code. > > Signed-off-by: Jeremy Linton > Reviewed-by: Sudeep Holla > --- > drivers/perf/arm_spe_pmu.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c > index 7cb766dafe85..ffa2c76c08bb 100644 > --- a/drivers/perf/arm_spe_pmu.c > +++ b/drivers/perf/arm_spe_pmu.c > @@ -1176,7 +1176,13 @@ static const struct of_device_id arm_spe_pmu_of_match[] = { > }; > MODULE_DEVICE_TABLE(of, arm_spe_pmu_of_match); > > -static int arm_spe_pmu_device_dt_probe(struct platform_device *pdev) > +static const struct platform_device_id arm_spe_match[] = { > + { "arm,spe-v1", 0}, It would be nice if we could avoid duplicating this string from the ACPI parsing code. > + { } > +}; > +MODULE_DEVICE_TABLE(platform, arm_spe_match); > + > +static int arm_spe_pmu_device_probe(struct platform_device *pdev) > { > int ret; > struct arm_spe_pmu *spe_pmu; > @@ -1236,11 +1242,12 @@ static int arm_spe_pmu_device_remove(struct platform_device *pdev) > } > > static struct platform_driver arm_spe_pmu_driver = { > + .id_table = arm_spe_match, > .driver = { > .name = DRVNAME, > .of_match_table = of_match_ptr(arm_spe_pmu_of_match), Hmm, so some other drivers don't hook .id_table like you do, but instead hook .acpi_match_table in the driver structure. Is that not better? Will