public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Okash Khawaja <okash.khawaja@gmail.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Gregory Nowak <greg@gregn.net>,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	Kirk Reiser <kirk@reisers.ca>,
	Peter Hurley <peter@hurleysoftware.com>,
	Jiri Slaby <jslaby@suse.com>,
	speakup@linux-speakup.org, John Covici <covici@ccs.covici.com>,
	Ben Hutchings <ben@decadent.org.uk>,
	Chris Brannon <chris@the-brannons.com>
Subject: Re: [PATCH 1/2] vt: selection: allow functions to be called from inside kernel
Date: Thu, 4 Apr 2019 22:35:49 +0200	[thread overview]
Message-ID: <20190404203549.GA9319@kroah.com> (raw)
In-Reply-To: <20190404194530.1170-2-okash.khawaja@gmail.com>

On Thu, Apr 04, 2019 at 08:45:29PM +0100, Okash Khawaja wrote:
> diff --git a/include/linux/selection.h b/include/linux/selection.h
> index a8f5b97b216f..171d77dfc825 100644
> --- a/include/linux/selection.h
> +++ b/include/linux/selection.h
> @@ -11,13 +11,12 @@
>  #include <linux/tiocl.h>
>  #include <linux/vt_buffer.h>
>  
> -struct tty_struct;
> -

Nit, why remove these lines?

thanks,

greg k-h

  reply	other threads:[~2019-04-04 20:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 19:45 [PATCH 0/2] staging: speakup: factor out selection code Okash Khawaja
2019-04-04 19:45 ` [PATCH 1/2] vt: selection: allow functions to be called from inside kernel Okash Khawaja
2019-04-04 20:35   ` Greg Kroah-Hartman [this message]
2019-04-04 20:48     ` Samuel Thibault
2019-04-16 11:37   ` Greg Kroah-Hartman
2019-04-04 19:45 ` [PATCH 2/2] staging: speakup: refactor to use existing code in vt Okash Khawaja
2019-04-17 12:21 ` [PATCH v2 0/2] staging: speakup: factor out selection code Okash Khawaja
2019-04-17 12:21   ` [PATCH v2 1/2] vt: selection: allow functions to be called from inside kernel Okash Khawaja
2019-04-17 12:21   ` [PATCH v2 2/2] staging: speakup: refactor to use existing code in vt Okash Khawaja
2019-04-19 13:11   ` [PATCH v2 0/2] staging: speakup: factor out selection code Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190404203549.GA9319@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ben@decadent.org.uk \
    --cc=chris@the-brannons.com \
    --cc=covici@ccs.covici.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=greg@gregn.net \
    --cc=jslaby@suse.com \
    --cc=kirk@reisers.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=okash.khawaja@gmail.com \
    --cc=peter@hurleysoftware.com \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=speakup@linux-speakup.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox