From: Dan Carpenter <dan.carpenter@oracle.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Caio Salvador Rohwedder <caiosalvador96@gmail.com>,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
lkcamp@lists.libreplanetbr.org, linux-kernel@vger.kernel.org,
johnfwhitmore@gmail.com
Subject: Re: [PATCH] staging: rtl8192u: ieee80211: add space around '==' and before '('
Date: Fri, 5 Apr 2019 08:11:47 +0300 [thread overview]
Message-ID: <20190405051147.GN32590@kadam> (raw)
In-Reply-To: <e595121b-81f1-8242-eb91-a9258b96831d@huawei.com>
On Fri, Apr 05, 2019 at 10:31:17AM +0800, YueHaibing wrote:
> On 2019/4/5 9:56, Caio Salvador Rohwedder wrote:
> > if(!list_empty(pUnusedList)) {
> > (*ppTS) = list_entry(pUnusedList->next, struct ts_common_info, list);
> > list_del_init(&(*ppTS)->list);
> > - if(TxRxSelect==TX_DIR) {
> > + if (TxRxSelect == TX_DIR) {
> > struct tx_ts_record *tmp = container_of(*ppTS, struct tx_ts_record, ts_common_info);
>
> This line seems over 80 characters, may also be fixed.
>
The 80 character problem isn't really related to the "space required"
problem. Those would need to be fixed in separate patches.
> In fact, this file has so many code style issues, see
>
> ./scripts/checkpatch.pl --no-tree -f drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
>
Yes. Of course it has millions of style issues. It's staging code.
Leave it. We'll fix it little by little.
That said, I kind of would prefer to review patches which fix all the
"space[s] required" checkpatch warnings in a file in one go...
regards,
dan carpenter
prev parent reply other threads:[~2019-04-05 5:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 1:56 [PATCH] staging: rtl8192u: ieee80211: add space around '==' and before '(' Caio Salvador Rohwedder
2019-04-05 2:31 ` YueHaibing
2019-04-05 5:11 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405051147.GN32590@kadam \
--to=dan.carpenter@oracle.com \
--cc=caiosalvador96@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnfwhitmore@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkcamp@lists.libreplanetbr.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox