From: Borislav Petkov <bp@alien8.de>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: LKML <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH] overflow.h: Rename __ab_c_size() to __calc_size()
Date: Fri, 5 Apr 2019 09:52:51 +0200 [thread overview]
Message-ID: <20190405075251.GC23348@zn.tnic> (raw)
In-Reply-To: <d2e7ee85-50a7-7026-82f9-2169656bd4f9@rasmusvillemoes.dk>
On Fri, Apr 05, 2019 at 08:26:45AM +0200, Rasmus Villemoes wrote:
> I like the current color.
Color?
> It computes a*b+c with overflow checking at each step. calc_size
> is way too generic and doesn't say anything at all about how the
> calc(ulation) is done.
Ok, whatever.
Then it would need at least a comment above it to state what it does. I
don't want to go and parse the macros each time.
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-04-05 7:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 4:57 [PATCH] overflow.h: Rename __ab_c_size() to __calc_size() Borislav Petkov
2019-04-05 6:26 ` Rasmus Villemoes
2019-04-05 7:52 ` Borislav Petkov [this message]
2019-04-05 8:09 ` Rasmus Villemoes
2019-04-05 8:24 ` Borislav Petkov
2019-04-05 16:13 ` Kees Cook
2019-04-05 16:25 ` Matthew Wilcox
2019-04-06 9:32 ` Borislav Petkov
2019-04-06 11:32 ` Rasmus Villemoes
2019-04-10 20:40 ` [tip:core/core] overflow.h: Add comment documenting __ab_c_size() tip-bot for Rasmus Villemoes
2019-04-12 11:49 ` tip-bot for Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405075251.GC23348@zn.tnic \
--to=bp@alien8.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox